-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing duplicates PPSTM_simple #33
Comments
This is a good idea. I was working on something along these lines a while back for the ASD-STM paper but never tested with other codes, fixed scans, output types etc. Heavily influenced by AFMulator in ppafm. The idea here is to create a STMulator object that can be initialised with scan parameters (params.ini, command line arguments), Lines 19 to 54 in c329d19
and then called with the molecule parameters Lines 121 to 135 in c329d19
Any thoughts on this approach? |
For this, I would also like to reorganise def cut_eigenenergies(eig, e_min, e_max):
"""
Removes eigenenergies not within range [e_min, e_max].
"""
mask = (eig > e_min) & (eig < e_max)
return eig[mask] |
Ok sounds good to me, just I would do that in the beginning of the code so we spare memory .
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Lauri Kurki ***@***.***>
Sent: Tuesday, September 17, 2024 8:23:08 AM
To: Probe-Particle/PPSTM ***@***.***>
Cc: Krejci Ondrej ***@***.***>; Author ***@***.***>
Subject: Re: [Probe-Particle/PPSTM] Removing duplicates PPSTM_simple (Issue #33)
For this, I would also like to reorganise readSTM.py a bit, so that we pass cut_min, cut_max, cut_atoms etc. to the corresponding functions instead of using initial_check to set global variables. For example cut_eigenenergies would look something like
def cut_eigenenergies(eig, e_min, e_max):
"""
Removes eigenenergies not within range [e_min, e_max].
"""
mask = (eig > e_min) & (eig < e_max)
return eig[mask]
—
Reply to this email directly, view it on GitHub<#33 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADFZAFLXGDXKXPBGEC6UVD3ZW64DZAVCNFSM6AAAAABN6PVLQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJUGU2TAMZYGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
About the STMumlator - yes, that was exactly what I was thinking about. Is it working or not? If so, then the only thing is a missing documentation. |
It is working for FHI-aims input with relaxed scan and v-scan, but it needs to be tested for other settings before pushing to master branch. |
If we want to avoid the many files in tests, we could also probably switch to a configuration file parameter setup like in ppafm (using My idea is that you could use python run_ppstm.py config.toml where Lines 15 to 67 in 3e15f45
With this approach it should be straightforward to add the |
Let's create a one function in
pyPPSTM
that would do anything from line 70 of PPSTM_simple.py;The text was updated successfully, but these errors were encountered: