New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nPBC z parameter should be 0 ? #236

Open

2 tasks

ondrejkrejci opened this issue Nov 14, 2023 · 1 comment

Assignees

Labels

Collaborator

ondrejkrejci commented Nov 14, 2023

should we change the nPBC z parameter default to 0 as it is not doing anything at all? Maybe even adding additional check for it.
Should we remove the PBC true/false from the external parameters. @ProkopHapala thinks that we should have inside the code still as it is easier to debug.

ondrejkrejci added the enhancement label

ondrejkrejci self-assigned this

Collaborator

ProkopHapala commented Mar 13, 2024

Yes, I think both suggestions makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment