Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels need to be added to the color bar in PNG images #253

Open
mondracek opened this issue Jan 22, 2024 · 3 comments · Fixed by #254
Open

Labels need to be added to the color bar in PNG images #253

mondracek opened this issue Jan 22, 2024 · 3 comments · Fixed by #254
Assignees

Comments

@mondracek
Copy link
Collaborator

The color bar in the PNG figures created by ppafm-plot-results, like df_*.png, LCPD _*.png is labeled by numbers only, without the name of the unit or quantity indicated. I am about to file a PR that will add a "df [Hz]" label for AFM images and "V_LCPD [V]" for LCPD images. More such labels can be added e.g. into tip displacement maps, Laplace-filtered df images, and IETS images, but I would prefer someone else doing it, somebody who actually knows what the units should be in those cases.

@mondracek
Copy link
Collaborator Author

@ondrejkrejci , thanks for merging the PR #254. I am going to reopen this issue so that we would not miss the opportunity to add the labels for the IETS etc. too, but this is low priority and can be done in a separate PR after we are done with the paper. The df [Hz] and V_LCPD labels were needed for the figure that is going to the paper, so good that these are merged into main.

@mondracek mondracek reopened this Jan 23, 2024
@ondrejkrejci
Copy link
Collaborator

@mondracek - is this still open? Because of IETS and KPFM?

@mondracek
Copy link
Collaborator Author

Because of IETS and Laplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants