-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the storage for examples #314
Comments
Another thought about this: I made a while ago a Python function for easily downloading datasets in the GPU scripts here: Lines 47 to 49 in 12a9034
It downloads and unpacks a named dataset to a chosen location while printing a progress percentage, and skips the download if the destination already exists. Maybe we could make a CLI command for this, something like ppafm-download [DATASET_NAME] [SAVE_PATH] This would somewhat simplify the code and avoid repeated downloads in the CLI scripts. |
Question @ondrejkrejci @NikoOinonen @yakutovicha - so should I upload to zenodo directly the directory structure of the examples with the downloaded files? Perhaps that would be most easy to navigate ? |
I am not sure if it is possible. If so, then it is the easiest, otherwise I would rename those as 'directory-filename.tgz' so it is the same and easy to understand |
I think we want one compressed file per example, so that they can be downloaded individually. Also, we only need to upload the big files (.xsf), not the ones that only use an xyz geometry. |
Hi, @NikoOinonen @ondrejkrejci @yakutovicha @mondracek I downloaded all files form example (unless I forgot something), and I'm prepared to upload them. I think it would be better to put them in a flat directory structure, and make a I suggest these directories:
Please let me know if I forgot something, or if you have different suggestion Some notes:
Just for comparison there is current directroy strcuture of the examples (after downloading the files by the scripts)
|
If I recall, the
Yes, there is an interpolation step that resamples the input file grids to the specified FF grid. |
Aha, I see, they are really the same (by And what is Anyway - if nobody ( @ondrejkrejci @yakutovicha @mondracek ) has any suggestions/ objections I will procede with uploading. |
I agree. Maybe it is a question, why having that many PTCDA examples now, but historically they have their place. |
Go ahead @ProkopHapala. In the worst case (if something won't be organised optimally) we can always make v2 👍 . |
It is the delta electron density, difference from free atom density, that I used for the electrostatics part in the FDBM simulations in the paper. |
Ok, so I did it. Now I sould mofidy the examples to download it properly |
@ProkopHapala, I think the pyridine upload misses the tip data. |
I think that is OK, the tip data can be copied from the The grids are the same but we need to modify the scripts |
Thanks, @ProkopHapala, I will then update the part I am working on 👍 |
While working on # 233 and trying not to change the results there, I have found out that our examples are files are scattered all over the place - Zenodo, Dropbox, Mega ...
The most of all, I do not like that the pyridineDensOverlap/run.sh needs sudo for mega tools.
I am suggesting to move everything to Zenodo and adjust the examples accordingly. Let's discuss this,
The text was updated successfully, but these errors were encountered: