Skip to content

Commit 0355bfb

Browse files
committed
address comments
Signed-off-by: YunLiu <[email protected]>
1 parent 4c877dc commit 0355bfb

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

monai/inferers/merger.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,13 +249,13 @@ def __init__(
249249
self.store = store
250250
if version_geq(get_package_version("zarr"), "3.0.0"):
251251
if value_store is None:
252-
with TemporaryDirectory() as tmpdir:
253-
self.value_store = zarr.storage.LocalStore(tmpdir)
252+
tmpdir = TemporaryDirectory()
253+
self.value_store = zarr.storage.LocalStore(tmpdir.name)
254254
else:
255255
self.value_store = value_store
256256
if count_store is None:
257-
with TemporaryDirectory() as tmpdir:
258-
self.count_store = zarr.storage.LocalStore(tmpdir)
257+
tmpdir = TemporaryDirectory()
258+
self.count_store = zarr.storage.LocalStore(tmpdir.name)
259259
else:
260260
self.count_store = count_store
261261
else:

tests/test_zarr_avg_merger.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -287,19 +287,16 @@ class ZarrAvgMergerTests(unittest.TestCase):
287287
]
288288
)
289289
def test_zarr_avg_merger_patches(self, arguments, patch_locations, expected):
290+
codec_reg = numcodecs.registry.codec_registry
290291
if "compressor" in arguments:
291292
if arguments["compressor"] != "default":
292-
arguments["compressor"] = numcodecs.registry.codec_registry[arguments["compressor"].lower()]()
293+
arguments["compressor"] = codec_reg[arguments["compressor"].lower()]()
293294
if "value_compressor" in arguments:
294295
if arguments["value_compressor"] != "default":
295-
arguments["value_compressor"] = numcodecs.registry.codec_registry[
296-
arguments["value_compressor"].lower()
297-
]()
296+
arguments["value_compressor"] = codec_reg[arguments["value_compressor"].lower()]()
298297
if "count_compressor" in arguments:
299298
if arguments["count_compressor"] != "default":
300-
arguments["count_compressor"] = numcodecs.registry.codec_registry[
301-
arguments["count_compressor"].lower()
302-
]()
299+
arguments["count_compressor"] = codec_reg[arguments["count_compressor"].lower()]()
303300
merger = ZarrAvgMerger(**arguments)
304301
for pl in patch_locations:
305302
merger.aggregate(pl[0], pl[1])

0 commit comments

Comments
 (0)