Skip to content

Commit 149a5bb

Browse files
committed
Fixing pickle protocol issue
Signed-off-by: Eric Kerfoot <[email protected]>
1 parent 9b171d4 commit 149a5bb

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

tests/data/test_gdsdataset.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ def test_cache(self):
8686
cache_dir=tempdir,
8787
device=0,
8888
pickle_module="pickle",
89-
pickle_protocol=pickle.HIGHEST_PROTOCOL,
89+
# TODO: was pickle.HIGHEST_PROTOCOL but this wasn't compatible with torch.load, need to improve compatibility
90+
pickle_protocol=torch.serialization.DEFAULT_PROTOCOL,
9091
)
9192
assert_allclose(items[0], p(np.arange(0, np.prod(shape)).reshape(shape)))
9293
ds1 = GDSDataset(items, transform=_InplaceXform(), cache_dir=tempdir, device=0)

tests/data/test_persistentdataset.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
from __future__ import annotations
1313

1414
import os
15-
import pickle
1615
import tempfile
1716
import unittest
1817

1918
import nibabel as nib
2019
import numpy as np
20+
import torch
2121
from parameterized import parameterized
2222

2323
from monai.data import PersistentDataset, json_hashing
@@ -66,7 +66,8 @@ def test_cache(self):
6666
transform=_InplaceXform(),
6767
cache_dir=tempdir,
6868
pickle_module="pickle",
69-
pickle_protocol=pickle.HIGHEST_PROTOCOL,
69+
# TODO: was pickle.HIGHEST_PROTOCOL but this wasn't compatible with torch.load, need to improve compatibility
70+
pickle_protocol=torch.serialization.DEFAULT_PROTOCOL,
7071
)
7172
self.assertEqual(items, [[[]], [[0]], [[0, 1]], [[0, 1, 2]], [[0, 1, 2, 3]]])
7273
ds1 = PersistentDataset(items, transform=_InplaceXform(), cache_dir=tempdir)

0 commit comments

Comments
 (0)