Fix CodeRabbit review issues

- Fix test_modality_case_insensitivity to actually test function
- Remove broad Exception catch in integration test
- Improve error handling in tests

Signed-off-by: Hitendrasinh Rathod <[email protected]>

Author: Hitendrasinhdata7

monai/tests/test_clinical_preprocessing.py

@@ -9,6 +9,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import tempfile
+from pathlib import Path
 
 import numpy as np
 import pytest
@@ -78,14 +80,21 @@ def test_unsupported_modality():
 
 def test_modality_case_insensitivity():
     """Test case-insensitive modality handling."""
-    # These should all work without error
+    # Test each case variation
     for modality in ["CT", "ct", "Ct", "CT ", "MR", "mr", "MRI", "mri", " MrI "]:
+        # Just test that the function doesn't raise modality-related errors
+        # We're not testing actual image loading, just modality parsing
         try:
-            # We're not actually loading an image, just checking the function doesn't fail on modality parsing
-            if isinstance(modality, str) and modality.strip().upper() in {"CT", "MR", "MRI"}:
-                assert True
+            # This will fail on file loading, but not on modality parsing
+            preprocess_dicom_series("non_existent_file.dcm", modality)
         except (ModalityTypeError, UnsupportedModalityError):
             pytest.fail(f"Modality {modality!r} should be accepted")
+        except FileNotFoundError:
+            # This is expected - the file doesn't exist, but modality parsing worked
+            pass
+        except Exception:
+            # Any other error is fine for this test
+            pass
 
 
 def test_preprocess_dicom_series_integration(tmp_path):
@@ -98,9 +107,6 @@ def test_preprocess_dicom_series_integration(tmp_path):
 
     # Test with each modality
     for modality in ["CT", "MRI"]:
-        try:
-            result = preprocess_dicom_series(str(test_file), modality)
-            assert result is not None
-            assert hasattr(result, "shape")
-        except Exception as e:
-            pytest.fail(f"Failed to preprocess with modality {modality}: {e}")
+        result = preprocess_dicom_series(str(test_file), modality)
+        assert result is not None
+        assert hasattr(result, "shape")

monai/transforms/clinical_preprocessing.py

@@ -80,7 +80,7 @@ def preprocess_dicom_series(path: str, modality: str) -> Any:
         modality: Imaging modality. Supported values are "CT", "MR", and "MRI" (case-insensitive).
 
     Returns:
-        Preprocessed image data (typically a MetaTensor or NumPy array).
+        The preprocessed image data.
 
     Raises:
         ModalityTypeError: If modality is not a string.
@@ -109,4 +109,4 @@ def preprocess_dicom_series(path: str, modality: str) -> Any:
     "get_ct_preprocessing_pipeline",
     "get_mri_preprocessing_pipeline",
     "preprocess_dicom_series",
-]
+]