Complete fix for all CI and code review issues

- Remove MetaTensor import/type hint to fix CI failures
- Fix weak assertions with OR operator (now separate assertions)
- Add verification of all key constructor arguments
- Use Mock instead of lambda to avoid lint warnings
- Update docstrings and error handling
- Address all previous review feedback

Author: Hitendrasinhdata7

monai/tests/test_clinical_preprocessing.py

@@ -26,8 +26,8 @@ def test_ct_preprocessing_pipeline():
     assert scale_transform.b_min == 0.0
     assert scale_transform.b_max == 1.0
     assert scale_transform.clip is True
-
-    # Verify LoadImage configuration (as suggested in review)
+    
+    # Verify LoadImage configuration
     load_transform = pipeline.transforms[0]
     assert load_transform.image_only is True
 
@@ -44,20 +44,19 @@ def test_mri_preprocessing_pipeline():
     # Verify MRI-specific normalization parameter
     normalize_transform = pipeline.transforms[2]
     assert normalize_transform.nonzero is True
-
-    # Verify LoadImage configuration (as suggested in review)
+    
+    # Verify LoadImage configuration
     load_transform = pipeline.transforms[0]
     assert load_transform.image_only is True
 
 
 def test_preprocess_dicom_series_invalid_modality():
     """Test preprocess_dicom_series raises UnsupportedModalityError for unsupported modality."""
-    # More robust error matching (as suggested in review)
     with pytest.raises(UnsupportedModalityError) as exc_info:
         preprocess_dicom_series("dummy_path.dcm", "PET")
-
+    
     error_message = str(exc_info.value)
-    # Check that all required strings are present (NO OR OPERATOR - separate assertions)
+    # Check that all required strings are present (separate assertions, no OR operator)
     assert "CT" in error_message
     assert "MR" in error_message
     assert "MRI" in error_message
@@ -71,15 +70,10 @@ def test_preprocess_dicom_series_invalid_type():
         preprocess_dicom_series("dummy_path.dcm", 123)
 
 
-# ------------------------
-# Tests for valid modalities
-# ------------------------
-
 @patch("monai.transforms.clinical_preprocessing.get_ct_preprocessing_pipeline")
 def test_preprocess_dicom_series_ct(mock_pipeline):
     """Test preprocess_dicom_series successfully runs for CT modality."""
     dummy_output = "ct_processed"
-    # Fixed: Use Mock instead of lambda with unused argument (as suggested in review)
     mock_pipeline.return_value = Mock(return_value=dummy_output)
     result = preprocess_dicom_series("dummy_path.dcm", "CT")
     assert result == dummy_output
@@ -93,11 +87,10 @@ def test_preprocess_dicom_series_ct(mock_pipeline):
 def test_preprocess_dicom_series_mr(mock_pipeline):
     """Test preprocess_dicom_series successfully runs for MR modality."""
     dummy_output = "mr_processed"
-    # Fixed: Use Mock instead of lambda with unused argument (as suggested in review)
     mock_pipeline.return_value = Mock(return_value=dummy_output)
     result = preprocess_dicom_series("dummy_path.dcm", "MR")
     assert result == dummy_output
 
     # Test lowercase and "MRI" variant
     result2 = preprocess_dicom_series("dummy_path.dcm", "mri")
-    assert result2 == dummy_output
+    assert result2 == dummy_output

monai/transforms/clinical_preprocessing.py

@@ -5,7 +5,6 @@
 """
 
 from monai.transforms import Compose, LoadImage, EnsureChannelFirst, ScaleIntensityRange, NormalizeIntensity
-from monai.data import MetaTensor
 
 
 class ModalityTypeError(TypeError):
@@ -21,15 +20,15 @@ class UnsupportedModalityError(ValueError):
 def get_ct_preprocessing_pipeline() -> Compose:
     """
     Create a preprocessing pipeline for CT (Computed Tomography) images.
-
+    
     Returns:
         Compose: A transform composition for CT preprocessing.
-
+        
     The pipeline consists of:
     1. LoadImage - Load DICOM series
     2. EnsureChannelFirst - Add channel dimension
     3. ScaleIntensityRange - Scale Hounsfield Units (HU) from [-1000, 400] to [0, 1]
-
+    
     Note:
         The HU window [-1000, 400] is a common soft tissue window.
     """
@@ -43,15 +42,15 @@ def get_ct_preprocessing_pipeline() -> Compose:
 def get_mri_preprocessing_pipeline() -> Compose:
     """
     Create a preprocessing pipeline for MRI (Magnetic Resonance Imaging) images.
-
+    
     Returns:
         Compose: A transform composition for MRI preprocessing.
-
+        
     The pipeline consists of:
     1. LoadImage - Load DICOM series
     2. EnsureChannelFirst - Add channel dimension
     3. NormalizeIntensity - Normalize non-zero voxels
-
+    
     Note:
         Normalization is applied only to non-zero voxels to avoid bias from background.
     """
@@ -62,33 +61,33 @@ def get_mri_preprocessing_pipeline() -> Compose:
     ])
 
 
-def preprocess_dicom_series(path: str, modality: str) -> MetaTensor:
+def preprocess_dicom_series(path: str, modality: str):
     """
     Preprocess a DICOM series based on the imaging modality.
-
+    
     Args:
         path: Path to the DICOM series directory or file.
         modality: Imaging modality (case-insensitive). Supported values:
                   "CT", "MR", "MRI" (MRI is treated as synonym for MR).
-
+    
     Returns:
-        MetaTensor: The preprocessed image data with metadata.
-
+        The preprocessed image data.
+    
     Raises:
         ModalityTypeError: If modality is not a string.
         UnsupportedModalityError: If modality is not supported.
     """
     # Validate input type
     if not isinstance(modality, str):
         raise ModalityTypeError(f"modality must be a string, got {type(modality).__name__}")
-
+    
     # Normalize modality string (strip whitespace, convert to uppercase)
     modality_clean = modality.strip().upper()
-
+    
     # Map MRI to MR (treat as synonyms)
     if modality_clean == "MRI":
         modality_clean = "MR"
-
+    
     # Select appropriate preprocessing pipeline
     if modality_clean == "CT":
         pipeline = get_ct_preprocessing_pipeline()
@@ -99,16 +98,16 @@ def preprocess_dicom_series(path: str, modality: str) -> MetaTensor:
         raise UnsupportedModalityError(
             f"Unsupported modality '{modality}'. Supported modalities: {', '.join(supported)}"
         )
-
+    
     # Apply preprocessing pipeline
     return pipeline(path)
 
 
 # Export the public API
 __all__ = [
     "ModalityTypeError",
-    "UnsupportedModalityError",
+    "UnsupportedModalityError", 
     "get_ct_preprocessing_pipeline",
     "get_mri_preprocessing_pipeline",
     "preprocess_dicom_series",
-]
+]