Skip to content

Commit a375354

Browse files
committed
Update Zarr tests to include compression tests only with versions before 3.0
Signed-off-by: Eric Kerfoot <[email protected]>
1 parent 8ac8e0d commit a375354

File tree

1 file changed

+25
-24
lines changed

1 file changed

+25
-24
lines changed

tests/test_zarr_avg_merger.py

Lines changed: 25 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@
202202

203203
# test for LZ4 compressor
204204
TEST_CASE_13_COMPRESSOR_LZ4 = [
205-
dict(merged_shape=TENSOR_4x4.shape, compressor="LZ4"),
205+
dict(merged_shape=TENSOR_4x4.shape, compressor=zarr.codecs.BloscCodec),
206206
[
207207
(TENSOR_4x4[..., :2, :2], (0, 0)),
208208
(TENSOR_4x4[..., :2, 2:], (0, 2)),
@@ -260,37 +260,38 @@
260260
TENSOR_4x4,
261261
]
262262

263+
ALL_TESTS = [
264+
TEST_CASE_0_DEFAULT_DTYPE,
265+
TEST_CASE_1_DEFAULT_DTYPE,
266+
TEST_CASE_2_DEFAULT_DTYPE,
267+
TEST_CASE_3_DEFAULT_DTYPE,
268+
TEST_CASE_4_DEFAULT_DTYPE,
269+
TEST_CASE_5_VALUE_DTYPE,
270+
TEST_CASE_6_COUNT_DTYPE,
271+
TEST_CASE_7_COUNT_VALUE_DTYPE,
272+
TEST_CASE_8_DTYPE,
273+
TEST_CASE_9_LARGER_SHAPE,
274+
TEST_CASE_10_DIRECTORY_STORE,
275+
TEST_CASE_11_MEMORY_STORE,
276+
TEST_CASE_12_CHUNKS,
277+
TEST_CASE_16_WITH_LOCK,
278+
TEST_CASE_17_WITHOUT_LOCK,
279+
]
280+
281+
# add compression tests only when using Zarr version before 3.0
282+
if not version_geq(get_package_version("zarr"), "3.0.0"):
283+
ALL_TESTS += [TEST_CASE_13_COMPRESSOR_LZ4, TEST_CASE_14_COMPRESSOR_PICKLE, TEST_CASE_15_COMPRESSOR_LZMA]
284+
263285

264286
@unittest.skipUnless(has_zarr and has_numcodecs, "Requires zarr (and numcodecs) packages.)")
265287
class ZarrAvgMergerTests(unittest.TestCase):
266288

267-
@parameterized.expand(
268-
[
269-
TEST_CASE_0_DEFAULT_DTYPE,
270-
TEST_CASE_1_DEFAULT_DTYPE,
271-
TEST_CASE_2_DEFAULT_DTYPE,
272-
TEST_CASE_3_DEFAULT_DTYPE,
273-
TEST_CASE_4_DEFAULT_DTYPE,
274-
TEST_CASE_5_VALUE_DTYPE,
275-
TEST_CASE_6_COUNT_DTYPE,
276-
TEST_CASE_7_COUNT_VALUE_DTYPE,
277-
TEST_CASE_8_DTYPE,
278-
TEST_CASE_9_LARGER_SHAPE,
279-
TEST_CASE_10_DIRECTORY_STORE,
280-
TEST_CASE_11_MEMORY_STORE,
281-
TEST_CASE_12_CHUNKS,
282-
TEST_CASE_13_COMPRESSOR_LZ4,
283-
TEST_CASE_14_COMPRESSOR_PICKLE,
284-
TEST_CASE_15_COMPRESSOR_LZMA,
285-
TEST_CASE_16_WITH_LOCK,
286-
TEST_CASE_17_WITHOUT_LOCK,
287-
]
288-
)
289+
@parameterized.expand(ALL_TESTS)
289290
def test_zarr_avg_merger_patches(self, arguments, patch_locations, expected):
290291
codec_reg = numcodecs.registry.codec_registry
291292
if "compressor" in arguments:
292293
if arguments["compressor"] != "default":
293-
arguments["compressor"] = codec_reg[arguments["compressor"].lower()]()
294+
arguments["compressor"] = arguments["compressor"]
294295
if "value_compressor" in arguments:
295296
if arguments["value_compressor"] != "default":
296297
arguments["value_compressor"] = codec_reg[arguments["value_compressor"].lower()]()

0 commit comments

Comments
 (0)