-
Notifications
You must be signed in to change notification settings - Fork 13
Labels
CLITypes(cript)Requires type definition or TypeScript related work / documentationRequires type definition or TypeScript related work / documentationenhancementImprove something existing (e.g. no docs, new APIs, etc)Improve something existing (e.g. no docs, new APIs, etc)good first issueGood for newcomersGood for newcomersv0.34.0
Description
Current State
Coming out of #1420, a handful of // @ts-nocheck
comments were sprinkled around the codebase, mostly dealing with ASTs and the like. Would be nice to give it a go and see if we can resolve as many of them as possible.
Desired State
We'll need to add JS files to tsconfig.json#include
{
"include": ["./packages/*/src/types/*.d.ts", "./*.ts", "./packages/*/src/*.js"],
}
Then removal as many // @ts-nocheck
comments and fix as many issue as possible from running yarn lint:types
, e..g
Found 15 errors in 9 files.
Errors Files
4 packages/cli/src/loader.js:9
3 packages/init/src/index.js:35
1 packages/init/src/util.js:28
1 packages/plugin-adapter-aws/src/index.js:128
1 packages/plugin-adapter-netlify/src/index.js:174
1 packages/plugin-adapter-vercel/src/index.js:149
2 packages/plugin-css-modules/src/index.js:84
1 packages/plugin-google-analytics/src/index.js:55
1 packages/plugin-import-commonjs/src/index.js:63
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for
Additional Context
No response
Metadata
Metadata
Assignees
Labels
CLITypes(cript)Requires type definition or TypeScript related work / documentationRequires type definition or TypeScript related work / documentationenhancementImprove something existing (e.g. no docs, new APIs, etc)Improve something existing (e.g. no docs, new APIs, etc)good first issueGood for newcomersGood for newcomersv0.34.0
Type
Projects
Status
🔖 Ready