Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IC CDK Storage bug #16

Open
blutooth opened this issue Dec 30, 2021 · 2 comments
Open

IC CDK Storage bug #16

blutooth opened this issue Dec 30, 2021 · 2 comments

Comments

@blutooth
Copy link

Any code that uses the IC CDK storage is using unsafe Rust which can result in race conditions. This may not introduce downstream issues in your code, but it was a problem for us, and certainly may be a problem if storage is used more widely throughout the codebase.

@ferencdg
Copy link

Can you be a bit more specific please? what issues did you face when using IC CDK? If the CDK is buggy we need to notify DFinity.

@Maximkaaa
Copy link

The issue @blutooth is referring to is raised in CDK ~3 years ago: dfinity/cdk-rs#73 . Quick look at the DIP20 code doesn't show any obvious UBs, but it's certainly a little sketchy, especially since it uses async calls to Cap (which allows other code to be executed while async is awaiting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants