Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ICRC1 standard to DIP20 #31

Open
hpeebles opened this issue Sep 22, 2023 · 2 comments
Open

Add support for ICRC1 standard to DIP20 #31

hpeebles opened this issue Sep 22, 2023 · 2 comments

Comments

@hpeebles
Copy link

Hey!

I am one of the developers building OpenChat.
Within OpenChat we support the sending of any ICRC1 tokens, but we have been asked a few times to also support DIP20 tokens.
We make use of subaccounts in a few cases to isolate user funds held by a single canister, so we cant use DIP20 due to its lack of support for subaccounts.
However, a year ago, @roman-kashitsyn (one of the Dfinity devs) came up with a solution (see here) that would allow us to easily add support for ICRC1 to the DIP20 ledger.
His proposed solution simply involves converting each {owner, subaccount} pair into a derived principal.
The core of the ledger remains exactly the same.

I'm keen to implement the solution proposed by Roman so I'm creating this issue to start the discussion and to see if others also think this is a good plan.

@5000slices1
Copy link

This is a good endeavor to add ICRC-1 support for Dip20 tokens. Otherwise, all DIP20 tokens are in their own world right now. This is a good move for ICP eco-system.

@Smugandcomfy
Copy link

Love this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants