Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mobile toolbar formatting + window cropping #227

Closed
emillipede opened this issue Nov 1, 2019 · 0 comments
Closed

update mobile toolbar formatting + window cropping #227

emillipede opened this issue Nov 1, 2019 · 0 comments
Labels
bug Something isn't working mobile work in progress

Comments

@emillipede
Copy link
Collaborator

emillipede commented Nov 1, 2019

as a:
mobile user

when I:
view the map

I want to:
see the labels "zoom to location" and "group by"

there are a few overlapping problems described in this issue.

labels:

  • the labels are not fully visible on most mobile phones
  • on my phone, "zoom to location" is stacked into two rows

buttons and address bar:

  • the buttons and address bar are not at the same height (not aligned)
  • on some displays, the buttons and address bar stick out below the toolbar (in mobile view, reduce toolbar white space #245)
  • the "species" and "family" buttons change size when they are selected and unselected and have irregular borders (see screenshot)
  • a gap sometimes appears between the two buttons (see screenshot)
  • the buttons have more padding than they do in the zeplin design (they become very wide on large mobile phones).
  • whenever extra width is available, the address bar should expand (not the width of the buttons)

mini/preview sidebar:

  • like the top of the page, the bottom of the page is also cropped. the photo and "view details" button are partially obscured (improve mobile display preview window #244)
  • when the preview bar is resized, the image, close button, and text don't adjust as a unit (they sometimes overlap) (reformat close buttons #186)
  • the preview sidebar also looks a little taller than in the zeplin (in the mock up, it's 120px high, 18% of the window height)

zeplin:
Screen Shot 2019-09-23 at 11 31 05 PM

current site:
Image from iOS (2)
Image from iOS (1)

@emillipede emillipede mentioned this issue Nov 1, 2019
@emillipede emillipede added help wanted Extra attention is needed mobile labels Nov 1, 2019
@emillipede emillipede changed the title update mobile toolbar formatting update mobile toolbar formatting + window cropping Nov 1, 2019
@emillipede emillipede added improvement bug Something isn't working labels Nov 1, 2019
@emillipede emillipede added work in progress and removed help wanted Extra attention is needed labels Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mobile work in progress
Projects
None yet
Development

No branches or pull requests

1 participant