Skip to content

Commit 870d777

Browse files
author
root
committed
suggested changes done
1 parent b6f4a2b commit 870d777

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

announce/server.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
def get_login():
1818
if not bottle.request.user.is_anon:
1919
return bottle.redirect(app.get_url("get_dashboard"))
20-
render("login.html")
20+
return render("login.html")
2121

2222

2323
@app.post("/login", name="post_login", skip=["login_required"])
@@ -70,8 +70,10 @@ def get_group(groupid, Group, Cred, Member):
7070
@fill_args
7171
def del_group(groupid,Group):
7272
session = bottle.request.session
73-
x = session.query(Group).get(groupid)
74-
session.delete(x)
73+
g = session.query(Group).filter_by(id=groupid).first()
74+
if g is None:
75+
return bottle.abort(404, 'no such group')
76+
session.delete(g)
7577
session.commit()
7678
return bottle.redirect(app.get_url("get_dashboard"))
7779

views/dash.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ <h2>Groups</h2>
88
<a href='{{ url_for('get_events', groupid=group.id) }}'>Events page</a> |
99
{{ group.name }} |
1010
<a href='{{ url_for('del_group', groupid=group.id) }}'>
11-
<button type="submit">Delete Group</button>
11+
<button>Delete Group</button>
1212
</a>
1313
</li>
1414
{% endfor %}

0 commit comments

Comments
 (0)