Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying maturin version by git commit/branch #228

Open
stinodego opened this issue Nov 12, 2023 · 1 comment
Open

Allow specifying maturin version by git commit/branch #228

stinodego opened this issue Nov 12, 2023 · 1 comment

Comments

@stinodego
Copy link

stinodego commented Nov 12, 2023

The maturin action only supports tagged releases, as documented in the README.

Recently, I ran into a bug and wanted to use the latest commit on the main branch to build my project. However, this is not currently possible. I have the git branch specified in my pyproject.toml:

[build-system]
requires = ["maturin @ git+https://github.com/PyO3/maturin.git@main"]
build-backend = "maturin"

Maturin action recognized this, but doesn't allow it and installs the latest released version (which does not include the fix I require).

Found maturin version requirement maturin @ git+https://github.com/PyO3/maturin.git@main specified in pyproject.toml
Warning: No maturin release found from requirement maturin @ git+https://github.com/PyO3/maturin.git@main, fallback to latest

It would be great if we could at least use the latest version on the main branch. Though I understand this may be hard to support.

@messense
Copy link
Member

Well, I guess it's not that hard to support, we could translate that into pip install https://github.com/PyO3/maturin/archive/refs/heads/<git-rev>.zip, but it's gonna be slow because it will compile maturin from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants