Repository navigation
Suggestion: Make it easier to know whether project is a valid mixed python/rust project #1843
dhruv-ahuja
started this conversation in
Ideas
Replies: 1 comment 1 reply
|
Thanks for the positive feedback. I'm not convinced that changing the message would help avoiding this issue, maybe it's better if we make project layout an explict option in |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hello guys, first of all, great job on the project! I recently used Maturin and Pyo3 for developing Rust bindings for my CLI song downloader app. It was generally a straightforward and pleasant experience.
However, since I had started coding first without trying to build a wheel, I did not realize that my Rust code was not being included in the wheel. I think that there should be an easier way of knowing whether the project that we're building is considered to be a valid mixed python/rust project or not.
Currently we only have a message
🍹 Building a mixed python/rust projectduring the build phase when runningmaturin build/maturin develop.Although the docs are very clear in this regard, I think adding a warning or info message, or tweaking the current message could further help and this could be colour-coded. Perhaps something like
You're building a Rust-only project, if this is a mixed Python/Rust project, please ensure that 'lib.name' matches Python directory name.It's possible that I'm the outlier here, since I do realize that the docs are really well-written and I did not have any issues whatsoever beyond this one. Please let me know your thoughts on the same.
Thank you!
All reactions