Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A safe API for upcasting #787

Open
davidhewitt opened this issue Mar 3, 2020 · 0 comments
Open

A safe API for upcasting #787

davidhewitt opened this issue Mar 3, 2020 · 0 comments

Comments

@davidhewitt
Copy link
Member

#770 initially implemented AsRef<Base> for PyRef<T>.

We had to remove that in #783 for native base types due to a safety issue in the implentation.

It would be ideal if AsRef could be implemented for PyRef<T> for both T and all bases of T - e.g. AsRef<T>, AsRef<T::Base>, AsRef<T::Base::Base> etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant