Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBML L3V1 support #52

Open
bgoli opened this issue Aug 16, 2021 · 2 comments
Open

SBML L3V1 support #52

bgoli opened this issue Aug 16, 2021 · 2 comments
Labels
enhancement Propose or request an enhancement to an existing feature.

Comments

@bgoli
Copy link
Member

bgoli commented Aug 16, 2021

Currently PySCeS imports/exports L2V4 and we need to deal with the model syntax (no defaults etc) as well as new/changes elements (event handling, math, packages, annotation).

@bgoli bgoli added the enhancement Propose or request an enhancement to an existing feature. label Aug 16, 2021
@bgoli bgoli added this to the 1.0 milestone Aug 16, 2021
@jmrohwer
Copy link
Member

Do you have any estimate of the amount of work involved in this? Can one be selective about this? E.g. do we have to deal with annotations? AFAICT they are in any case not part of the spec but used by tools for their own tool-specific stuff. Were you thinking of incorporating them into the PSC file in one way or another?

I was under the impression that we have dealt with events and math, amongst others in #53 and #46.

As regards packages, which packages should we support? Maybe start with core?
See also comments here: #51 (comment)

@bgoli
Copy link
Member Author

bgoli commented Aug 17, 2021

This is potentially some work

  • support for MIRIAM annotations and SBO is pretty much standard, so needs to be done at some point (I would store them in an auxiliary JSON/XML file and add support for loading, saving COMBINE archives that contain both files).
  • L3 changes the event handling a bit by introducing a priority ranking for triggering simultaneous events.
  • there are a few expanded symbols but Core features like InitialAssignments and the removal of all implicit defaults will need to be checked and tested (ideally I would like to rewrite the whole math subsystem to get rid of the infix evaluation but this is a big step so not for the near future, and only if it is faster)
  • Distrib and Comp would be the first I would look at adding some level of support for, but this is optional

@bgoli bgoli removed this from the 1.1 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Propose or request an enhancement to an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants