Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Implement a Modal component #9

Open
0x000011b opened this issue Feb 10, 2023 · 0 comments
Open

Implement a Modal component #9

0x000011b opened this issue Feb 10, 2023 · 0 comments

Comments

@0x000011b
Copy link
Contributor

Summary

We'll need a generic Modal component to handle all sorts of interactions in the UI, so having a preset shared component for this is a good idea.

It should be a horizontally and vertically-centered element that is positioned absolutely and is rendered above everything, including the navbar. It should stop the user from scrolling the content behind it while it's open. Think of something like this, for example.

Implementation suggestions

  • Should be implemented under src/shared/.
  • Probably the only props that will be needed are isVisible (for toggling visibility) and children (for populating the modal's body)
  • Ideally, we won't be using any external libraries for this to avoid bloat.
  • Don't worry too much about styling, as long as it vaguely fits with the rest of the stuff that already exists we can adjust down the line if necessary.
@0x000011b 0x000011b converted this from a draft issue Feb 10, 2023
@0x000011b 0x000011b moved this from 📋 Backlog to 🏗 In progress in Front-end Backlog Feb 10, 2023
@0x000011b 0x000011b moved this from 🏗 In progress to 👀 In review in Front-end Backlog Feb 18, 2023
@0x000011b 0x000011b linked a pull request Feb 18, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

1 participant