Website ReadMe Review

[Aquijada52]

Need to ensure that the steps exist for open source contributors to run the site locally and know how to contribute back to the project.

[giraudremi92]

I found out that i needed to install react create app before Yarn Start.
Maybe we need to write this in the Readme File ?
What do you think Guys ?

[upkarlidder]

Good catch! Thank you.

Did you mean react-scripts module? Would yarn install not take care of that? If so, we are missing yarn install in the readme.

❯ yarn start
yarn run v1.22.10
$ react-scripts start
/bin/sh: line 1: react-scripts: command not found
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

If I do yarn install followed by yarn start, the app works. Maybe you can create a pull request?

[giraudremi92]

Oops I'm not a yarn guy.
Yes yarn install take care of that i tried it.
I'll create a pull request tomorow for the Responsive Design, i'll try to create an other one for the Readme file and add yarn install in the Readme file ;)

[krook]

Thanks @giraudremi92!

[krook]

Thanks for the update. I followed the new readme steps and it worked well. The one thing I had to do in a new environment is to add yarn itself through brew install yarn.

[giraudremi92]

Ok, sure i have Yarn on my computer so I dindn't think about that.
Maybe we should add a comment that people will need Yarn for this project ?

[krook]

It makes sense. Maybe all we need is a sentence saying that you can get it from brew or other places for your particular machine.

[upkarlidder]

Agree with @krook. We don't tell them exactly how to install yarn. You can send them to https://classic.yarnpkg.com/en/docs/install. Basically yarn is a prerequisite for building and running the site.