Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing with Pycardano will fail in Python 3.12.0 (possibly use) #366

Open
ross-spencer opened this issue Jul 24, 2024 · 3 comments
Open

Comments

@ross-spencer
Copy link

Describe the bug

Pycardano failing 3.12.0 tests because of Blockfrost import.

To Reproduce

Try to test a feature requiring import of Pyardano in Python 3.12, the test will fail because 3.12.0 cannot import module pkg_resources via Blockfrost-Python.

Logs

On 3.10 we were already seeing deprecation warnings:

.tox/py3/lib/python3.10/site-packages/blockfrost/config.py:2
  /home/ross-spencer/git/orcfax/simple_sign/.tox/py3/lib/python3.10/site-packages/blockfrost/config.py:2: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    import pkg_resources

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

On 3.12:

.tox/py3/lib/python3.12/site-packages/blockfrost/config.py:2: in <module>
    import pkg_resources
E   ModuleNotFoundError: No module named 'pkg_resources'

Expected behavior

I'm not sure if this library is expected to work in 3.12.0 yet but it'd be great if it did.

Environment and software version (please complete the following information):

  • Python 3.12.
  • PyCardano 0.11.0

Additional context

Blockfrost hasn't been updated in this library since 0.5.3 - blockfrost is now on 0.6.0 and the dependency on pkg_resources has been removed, ref: blockfrost/blockfrost-python@add8f5b

@ross-spencer
Copy link
Author

Connected to: blockfrost/blockfrost-python#41

@cffls
Copy link
Collaborator

cffls commented Jul 27, 2024

Thanks. I will update the dependency as soon as blockfrost releases the new version.

@ross-spencer
Copy link
Author

@cffls blockfrost-python just pushed 6.0.0: https://pypi.org/project/blockfrost-python/0.6.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants