diff --git a/.github/workflows/on-main-push.yml b/.github/workflows/on-main-push.yml index 610709a597..affdf3583c 100644 --- a/.github/workflows/on-main-push.yml +++ b/.github/workflows/on-main-push.yml @@ -22,7 +22,8 @@ jobs: strategy: matrix: - java-version: [ 17, 11, 8 ] + # ISSUE on JDK 21 -- see on-pull-request.yml + java-version: [ 21, 17, 11 ] os: [ ubuntu-latest, macos-latest, windows-latest ] steps: @@ -47,8 +48,8 @@ jobs: mvnw install ^ -s %GITHUB_WORKSPACE%\settings.xml - deploy-for-jdk8: - name: jdk-8 snapshot publish + deploy-for-jdk11: + name: jdk-11 snapshot publish # ISSUE ChromeDriver/GeckoDriver fail to initialize on Ubuntu # see https://github.com/QA-Automation-Starter/qa-automation/actions/runs/3294884059/jobs/5432863668 # see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners @@ -61,7 +62,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-java@v3 with: - java-version: '8' + java-version: '11' distribution: 'temurin' cache: maven settings-path: ${{ github.workspace }} @@ -97,10 +98,15 @@ jobs: # same as in on-pull-request.yml generate-automation-project: name: Generates new automation project and builds it - needs: deploy-for-jdk8 + needs: deploy-for-jdk11 runs-on: ubuntu-latest steps: + - uses: actions/setup-java@v3 + with: + java-version: '11' + distribution: 'temurin' + - name: setup maven for sonatype snapshots uses: whelk-io/maven-settings-xml-action@v20 with: @@ -135,11 +141,12 @@ jobs: - name: generate testing project # ISSUE https://stackoverflow.com/questions/74581510/using-latest-for-archetypeversion-always-resolves-to-latest-release # NOTE will use last released archetype + # TODO after 1.0.0 release should change DarchetypeVersion to LATEST run: | mvn --batch-mode archetype:generate \ -DarchetypeGroupId=dev.aherscu.qa \ -DarchetypeArtifactId=qa-testing-archetype \ - -DarchetypeVersion=LATEST \ + -DarchetypeVersion=1.0.0-SNAPSHOT \ -DgroupId=com.acme \ -DartifactId=testing \ -Dversion=1.0-SNAPSHOT \ diff --git a/.github/workflows/on-pull-request.yml b/.github/workflows/on-pull-request.yml index 00d523821f..fe9b8becf5 100644 --- a/.github/workflows/on-pull-request.yml +++ b/.github/workflows/on-pull-request.yml @@ -19,7 +19,16 @@ jobs: strategy: matrix: - java-version: [ 17, 11, 8 ] + # ISSUE on JDK 21 -- + # when running aggregated as + # mvnw install mode-build-full mode-build-nosign testing-tutorials + # while running qa-testing-example: + # Cannot define class using reflection: Unable to make protected java.lang.Package + # when running verify on qa-testing-example standalone: + # java.lang.RuntimeException: ProcessBuilder.start() debug + # (in addition) + # In summary, on JDK 21 the tests do not work. + java-version: [ 21, 17, 11 ] os: [ ubuntu-latest, macos-latest, windows-latest ] steps: @@ -44,8 +53,8 @@ jobs: mvnw install ^ -s %GITHUB_WORKSPACE%\settings.xml - verify-for-jdk8: - name: jdk-8 verify + verify-for-jdk11: + name: jdk-11 verify # ISSUE ChromeDriver/GeckoDriver fail to initialize on Ubuntu # see https://github.com/QA-Automation-Starter/qa-automation/actions/runs/3294884059/jobs/5432863668 # see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners @@ -58,7 +67,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-java@v3 with: - java-version: '8' + java-version: '11' distribution: 'temurin' cache: maven settings-path: ${{ github.workspace }} @@ -102,10 +111,15 @@ jobs: generate-automation-project: name: generate-build-run-standalone - needs: verify-for-jdk8 + needs: verify-for-jdk11 runs-on: windows-latest steps: + - uses: actions/setup-java@v3 + with: + java-version: '11' + distribution: 'temurin' + - name: setup maven for sonatype snapshots uses: whelk-io/maven-settings-xml-action@v20 with: @@ -141,13 +155,14 @@ jobs: shell: cmd # ISSUE https://stackoverflow.com/questions/74581510/using-latest-for-archetypeversion-always-resolves-to-latest-release # NOTE will use last released archetype + # TODO after 1.0.0 release should change DarchetypeVersion to LATEST run: | mvn archetype:generate ^ --batch-mode ^ -Dmaven.wagon.http.ssl.insecure=true ^ -DarchetypeGroupId=dev.aherscu.qa ^ -DarchetypeArtifactId=qa-testing-archetype ^ - -DarchetypeVersion=LATEST ^ + -DarchetypeVersion=1.0.0-SNAPSHOT ^ -DgroupId=com.acme ^ -DartifactId=testing ^ -Dversion=0.0.1-SNAPSHOT ^ diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 796b750d13..1fbe71d6cd 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-java@v3 with: - java-version: '8' + java-version: '11' distribution: 'temurin' cache: maven settings-path: ${{ github.workspace }} diff --git a/.idea/misc.xml b/.idea/misc.xml index 2c804dfec9..e50e68f32d 100644 --- a/.idea/misc.xml +++ b/.idea/misc.xml @@ -1,3 +1,4 @@ + @@ -25,7 +26,7 @@ - + diff --git a/.idea/runConfigurations/rebuild_commons.xml b/.idea/runConfigurations/rebuild_commons.xml index 5d0af085df..e21d6727fd 100644 --- a/.idea/runConfigurations/rebuild_commons.xml +++ b/.idea/runConfigurations/rebuild_commons.xml @@ -11,7 +11,6 @@ +