-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Anisotropic Ewald code #2182
Open
jtkrogel
wants to merge
13
commits into
QMCPACK:develop
Choose a base branch
from
jtkrogel:anisotropic_ewald
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5a0ff83
add anisotropic ewald code
jtkrogel 5415831
remove commented code
jtkrogel 1c927f0
fix typos in comments
jtkrogel fd926a2
add namespace, const, and light function docs
jtkrogel f9db5f4
split off cpp file for EwaldRef
jtkrogel 8b06e0a
comparing aniso and qmcpack ewald
jtkrogel 00ef7f7
merge with develop
jtkrogel 51a77f7
start optimized ewald
jtkrogel 634e8c7
cleanup state machine
jtkrogel 1aa8058
rename functions
jtkrogel 9162af3
add SR and LR error bounds
jtkrogel 3ef40f0
add search to enforce bounds
jtkrogel d55eeba
enable accuracy vs time comparisons
jtkrogel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, please run clang-format on both files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not time efficient. I'm waiting for the automatic part of #794 to be implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automatic part has been implemented; see https://github.com/QMCPACK/qmcpack/wiki/Source-formatting
This was a decision made as a project to not have a robot do formatting without supervision, but to provide various methods for different workflow preferences that everyone can choose for themselves, from assisted manual to full automatic.