-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SPOSetT<T> template class hierarchy #4684
Open
williamfgc
wants to merge
4
commits into
QMCPACK:develop
Choose a base branch
from
williamfgc:ref-add-SPOSetT
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 9, 2023
-
Implement SPOSetT template class
Asses the effort to change this. Currently without consumers or tests. Concretize friend class declaration Define testing::getMyVars for SPOSetT Add FakeSPOT class Move SpinorSet to a templated class Refactor FreeOrbital class Base typed aliases on SPOSet<T> on OrbitalSetTraits<T> Add FullRealType in SPOSet and RotatedSPOs Add this in templated meta class Add explicit function instantions for FreeOrbital Add templated class SHOSetT Signed-off-by: Steven Hahn <[email protected]> Add PWRealOrbitalSetT template class Revert test_RotatedSPOs.cpp Revert test_RotatedSPOs.cpp Reorder specialized function definitions to appease OMP target compilation Add ConstantSPOSetT Refactor BsplineSet and SplineC2C Follow existing pattern for SplineC2C allowing for std::complex<T> PWOribitalSetT and PWBasisT Add FullRealType in SPOSet and RotatedSPOs Move generic definition after specialization add implicit implementations Fix some errors initial commit of templated PWOribitSetT that compiles cleanup templateitze PWBasis as well, as is dependancy remove inaccurate comment remove polluted commit Add LCAOrbitalSetT Add templated class LCAOrbitalSetWithCorrectionT Signed-off-by: Steven Hahn <[email protected]> Add SPOSetBuilderT, SHOSetBuilderT and SoaCuspCorrectionT Fix PWOrbitalSet alias types Fix LCAOrbitalSetWithCorrectionT Reuse SPOSet types Signed-off-by: Steven Hahn <[email protected]> Implement CompositeSPOSetT class Specialize functions in RotatedSPOsT Fix function signature Change order of definition Implement SPOSetBuilderFactoryT and most required builders Add missing implementation to SPOSetBuilderT Signed-off-by: Steven Hahn <[email protected]> Add CI to WIP refactoring branch add SplineR2RT Empty-Commit Further template propagation to fix offload build Implement SplineC2RTOMPTarget template class add missing particlesetT Refactored everything needed for test_RotatedSPOsT Add new bits to RotatedSPOsT Bugfix: removed QMC_COMPLEX conditions where no longer needed Accomodate new refactored headers simd::dot and Spline classes Move memory reference inside PRAGMA Causes a memory corruption when defining internal pos Fix pragma typo with is_device_ptr Implement SPOSetT template class Asses the initial effort to refactor SPOSet into templates without consumers or tests. Concretize friend class declaration Define testing::getMyVars for SPOSetT Add FakeSPOT class Move SpinorSet to a templated class Refactor FreeOrbital class Base typed aliases on SPOSet<T> on OrbitalSetTraits<T> Add FullRealType in SPOSet and RotatedSPOs Add this in templated meta class Add explicit function instantions for FreeOrbital Add templated class SHOSetT Add PWRealOrbitalSetT template class Revert test_RotatedSPOs.cpp Signed-off-by: Steven Hahn <[email protected]> Revert test_RotatedSPOs.cpp PWOribitalSetT and PWBasisT Add FullRealType in SPOSet and RotatedSPOs Move generic definition after specialization add implicit implementations Fix some errors initial commit of templated PWOribitSetT that compiles cleanup templateitze PWBasis as well, as is dependancy remove inaccurate comment remove polluted commit Start replacing legacy code with templated classes Fix ornl CI tests sulfur: Add missing SPOSet header in NiO tests nitrogen: Add missing memory header for std::unique_ptr clang-format-16 on new files Fix license file headers Fix typo with T1->T
Configuration menu - View commit details
-
Copy full SHA for 6a1b5f6 - Browse repository at this point
Copy the full SHA 6a1b5f6View commit details -
Remove test differences and fix build
Signed-off-by: Steven Hahn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 31a11f8 - Browse repository at this point
Copy the full SHA 31a11f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f919534 - Browse repository at this point
Copy the full SHA f919534View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3298e8 - Browse repository at this point
Copy the full SHA c3298e8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.