Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gif #13616

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Remove gif #13616

merged 8 commits into from
Jan 10, 2025

Conversation

abbycross
Copy link
Collaborator

@abbycross abbycross commented Jan 6, 2025

Closes Qiskit/documentation#2533. See discussion on this issue for context.

@abbycross abbycross requested a review from a team as a code owner January 6, 2025 15:42
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@abbycross abbycross self-assigned this Jan 6, 2025
@abbycross abbycross added the documentation Something is not clear or an error documentation label Jan 6, 2025
@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12692366220

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 88.922%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 91.98%
crates/qasm2/src/parse.rs 12 96.69%
Totals Coverage Status
Change from base Build 12687984222: -0.01%
Covered Lines: 79426
Relevant Lines: 89321

💛 - Coveralls

@Eric-Arellano Eric-Arellano requested a review from ElePT January 9, 2025 15:05
github-merge-queue bot pushed a commit to Qiskit/documentation that referenced this pull request Jan 9, 2025
Related to Qiskit/qiskit#13616. It was noted
that we do not have explanatory material on the concept of circuit
depth; adding it here.

---------

Co-authored-by: Kaelyn Ferris <[email protected]>
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this pull request to the merge queue Jan 10, 2025
@Eric-Arellano Eric-Arellano added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jan 10, 2025
Merged via the queue into Qiskit:main with commit b2d3df0 Jan 10, 2025
18 of 19 checks passed
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
* Remove gif

* Delete depth.gif

* Add explanatory snippet to depth method

* code review

Co-authored-by: Eric Arellano <[email protected]>

* Update quantumcircuit.py

---------

Co-authored-by: Eric Arellano <[email protected]>
(cherry picked from commit b2d3df0)
@mergify mergify bot mentioned this pull request Jan 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2025
* Remove gif

* Delete depth.gif

* Add explanatory snippet to depth method

* code review

Co-authored-by: Eric Arellano <[email protected]>

* Update quantumcircuit.py

---------

Co-authored-by: Eric Arellano <[email protected]>
(cherry picked from commit b2d3df0)

Co-authored-by: abbycross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deal with large and inaccessible Qiskit GIF
5 participants