-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13911 | Add ignoring of RuntimeWarning of aer in GenericBackendV2 test #13912
base: main
Are you sure you want to change the base?
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13530727959Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi LeanderCS, thanks for your contribution. If you read the issue carefully, you will notice that the proposed course of action is not stopping the issue of warnings inside the GenericBackendV2
class, but modifying the base test configuration to filter the warnings only during our unit test process. If you'd like to contribute to that, please revert the current change and apply the filter in the unit test base class.
d4fe035
to
6fb5ebe
Compare
@ElePT Do I understand it correctly, that you want the ignoring to be added inside of Why would the ignoring in the affected test be not suitable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I read the changes too quickly and assumed the filter was in the class not the test, so my previous comment didn't fully make sense. Let me clarify: the approach was not incorrect, but because the generic backend is widely used in other unit tests (and those were the ones causing the flooding of the logs), it's more efficient to have the filter in the base test class. LGTM, and thanks again.
Summary
Because the
aer
isn't available on all envs, the test logs get flooded with sometimes meaninglessDeprecationWarnings
.This PR adds that the affected class's error gets ignored in the tests.
Fixes #13911