Remove giant static QV file from benchmarks #13919
Open
+12
−215,012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The qasm2 import benchmarks included a qasm file that was a transpiled 100 qubit quantum volume circuit that was taken from benchpress. This qasm file had ~300,000 lines and was only being used as a benchmark of the qasm2 importer. However, this file is unceessarily large in the repo when we can just generate a large qasm file ourselves for the benchmark. This commit removes the file and rewrites the benchmark to generate a qasm file on the fly.
mtreinish
added
type: qa
|
One or more of the following people are relevant to this code:
|
jakelishman
reviewed
Feb 24, 2025
There was a problem hiding this comment.
In general this seems like a sensible thing to do, though we should be super confident that we're not blowing out the timeout in the setup - I know the quantum_volume function referred to here is still some super old one that's vendored into the benchmark suite to avoid invalidating the benchmarks when the Qiskit version updates.
Pull Request Test Coverage Report for Build 13566798063Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The qasm2 import benchmarks included a qasm file that was a transpiled 100 qubit quantum volume circuit that was taken from benchpress. This qasm file had ~300,000 lines and was only being used as a benchmark of the qasm2 importer. However, this file is unnecessarily large in the repo when we can just generate a large qasm file ourselves for the benchmark. This commit removes the file and rewrites the benchmark to generate a qasm file on the fly.
Details and comments