Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedcord not finding new content #51

Closed
LDannijs opened this issue Feb 12, 2025 · 8 comments
Closed

Feedcord not finding new content #51

LDannijs opened this issue Feb 12, 2025 · 8 comments
Labels
bug Something isn't working

Comments

@LDannijs
Copy link

Updated to V3 yesterday, and just saw a new Home Assistant release dropping, but i checked and my feed did not post to my discord. I am not quite sure what is going wrong here.

When i started it up, everything checked ok:

I: Status Code: 200 OK
I: Successfully initialized URL: https://github.com/home-assistant/core/releases.atom

However, it did not find the new release for Home Assistant when it came out:

I: Checking if any new posts for https://github.com/Qolors/FeedCord/releases.atom...
I: Checking if any new posts for https://github.com/home-assistant/core/releases.atom...
I: Checking if any new posts for https://github.com/louislam/dockge/releases.atom...
I: Checking if any new posts for https://github.com/amir20/dozzle/releases.atom...
I: Checking if any new posts for https://github.com/henrygd/beszel/releases.atom...
I: Checking if any new posts for https://github.com/paperless-ngx/paperless-ngx/releases.atom...
I: Checking if any new posts for https://github.com/louislam/uptime-kuma/releases.atom...
I: Checking if any new posts for https://github.com/immich-app/immich/releases.atom...
I: Home Assistant Alerts Finished Background Processing at 02/12/2025 20:12:36..
I: Github Releases Finished Background Processing at 02/12/2025 20:12:36..

Here is my appsettings.json

{
	"Instances": [
		{
			"Id": "Home Assistant Alerts",
			"Username": "Home Assistant Alerts",
			"RssUrls": [
				"https://alerts.home-assistant.io/feed.xml"
			],
			"YoutubeUrls": [ "" ],
			"DiscordWebhookUrl": "",
			"RssCheckIntervalMinutes": 30,
            "AvatarUrl":"https://raw.githubusercontent.com/home-assistant/alerts.home-assistant.io/refs/heads/master/static/favicon.png",
			"EnableAutoRemove": false,
			"Color": 1621234,
			"DescriptionLimit": 2000,
			"MarkdownFormat": false,
			"PersistenceOnShutdown": true,
			"Forum": false
		},
        {
			"Id": "Github Releases",
			"Username": "Github Releases",
			"RssUrls": [
                "https://github.com/home-assistant/core/releases.atom",
                "https://github.com/immich-app/immich/releases.atom",
                "https://github.com/louislam/dockge/releases.atom",
                "https://github.com/amir20/dozzle/releases.atom",
                "https://github.com/paperless-ngx/paperless-ngx/releases.atom",
                "https://github.com/louislam/uptime-kuma/releases.atom",
                "https://github.com/henrygd/beszel/releases.atom",
                "https://github.com/Qolors/FeedCord/releases.atom"
			],
			"YoutubeUrls": [ "" ],
			"DiscordWebhookUrl": "",
			"RssCheckIntervalMinutes": 60,
            "AvatarUrl":"https://cdn.jsdelivr.net/gh/selfhst/icons/png/github-light.png",
			"EnableAutoRemove": false,
			"Color": 2369838,
			"DescriptionLimit": 2000,
			"MarkdownFormat": false,
			"PersistenceOnShutdown": true,
			"Forum": false
		},
        {
			"Id": "Synology DSM",
			"Username": "Synology DSM",
			"RssUrls": [
                "https://kill-the-newsletter.com/feeds/"
			],
			"YoutubeUrls": [ "" ],
			"DiscordWebhookUrl": "",
			"RssCheckIntervalMinutes": 10,
			"EnableAutoRemove": false,
			"Color": 1621234,
			"DescriptionLimit": 2000,
			"MarkdownFormat": false,
			"PersistenceOnShutdown": true,
			"Forum": false
		}
	],
	"ConcurrentRequests": 40
}
@Qolors
Copy link
Owner

Qolors commented Feb 12, 2025

Hey there I was able to quickly find the issue with this. I unfortunately overlooked it the first go around when assuming a change I made was handling github feed issues..

FeedCord looks for 'publishingdate' in atom feeds, but github seems to ignore publishingdate and only uses 'updated' for their releases

FeedCord fails to parse publishingdate and defaults.. Oops

In other words, FeedCord defaults these item's publish dates to:
PublishDate = 01/01/0001 00:00:00 every time it checks so it's considered old forever

I'm going to be rolling a patch out tonight that I will group this in with - apologies on my overlook!

Thanks for sharing the issues - helps catch all these cases

@Qolors Qolors added the bug Something isn't working label Feb 12, 2025
@LDannijs
Copy link
Author

Thank you for your quick responding sir 🫡 I'll keep an eye out for the update and see if I come across more stuff haha.

I wonder if more logging could be added to catch these issues, since it doesn't show anything denoting it's not working properly right now.

@Qolors
Copy link
Owner

Qolors commented Feb 12, 2025

Totally agreed..

I will add "Verbose": true/false as a field for the config file to do just that. It can help with providing more info for opening issues too

Thanks

@trembon
Copy link

trembon commented Feb 13, 2025

updated to the beta docker build today and i have been getting notifications about github commits after the update, so seems to be working now

@Qolors
Copy link
Owner

Qolors commented Feb 13, 2025

Thanks for the feedback

Patch with this fix should be pushed to the latest image soon 👍

@LDannijs
Copy link
Author

@Qolors i don't mean to be an annoying person, but when will the patch drop?

@Qolors
Copy link
Owner

Qolors commented Feb 14, 2025

should drop some time this evening after I finish up the work day

@Qolors
Copy link
Owner

Qolors commented Feb 15, 2025

v3.0.2

Thanks!

@Qolors Qolors closed this as completed Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants