Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent Requests Per Instance #52

Closed
MrChuw opened this issue Feb 13, 2025 · 3 comments
Closed

Concurrent Requests Per Instance #52

MrChuw opened this issue Feb 13, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@MrChuw
Copy link

MrChuw commented Feb 13, 2025

While I was creating my feed channels

lore.kernel.org always returned

Failed to fetch RSS Feed after fallback attempts: http://lore.kernel.org/blablabla

by reducing ConcurrentRequests to 5, it can update normally

It would be interesting to be able to do something like this:

{
    "Instances": [
        {
            "Id": "Kernel Feed",
            "YoutubeUrls": [""],
            "RssUrls": [
                "https://lore.kernel.org/kernel-janitors/new.atom",
                "https://lore.kernel.org/git/new.atom"
                // "https://lore.kernel.org/kvm/new.atom",
                // "https://lore.kernel.org/linux-kernel/new.atom",
                // "https://lore.kernel.org/linux-kernel-announce/new.atom",
                // "https://lore.kernel.org/live-patching/new.atom",
                // "https://lore.kernel.org/stable/new.atom",
                // "https://lore.kernel.org/stable-rt/new.atom",
            ],
            "Forum": true,
            "DiscordWebhookUrl": "...",
            "RssCheckIntervalMinutes": 5,
            "EnableAutoRemove": true,
            "Color": 8411391,
            "DescriptionLimit": 1000,
            "MarkdownFormat": false,
            "PersistenceOnShutdown": true,
            "Username": "Kernel",
            "AvatarUrl": "https://img.icons8.com/?size=100&id=37823&format=png&color=000000",
            "FallbackImage": "https://www.kernel.org/theme/images/logos/tux.png",
			"ConcurrentRequests": 5													<------------------- Here is only for this instance.
        }
    ],
    "ConcurrentRequests": 40														<------------------- Here is only for all instances.
}
@Qolors
Copy link
Owner

Qolors commented Feb 13, 2025

So you were failing the fetch, but changing concurrent requests to 5 allowed you to start retrieving the feeds properly? Just making sure I'm understanding and you're not having an issue currently

Great idea here especially for your case where you're hitting the same domain in that instance. It can help with rate limiting and just overall better control.

@Qolors Qolors added the enhancement New feature or request label Feb 13, 2025
@MrChuw
Copy link
Author

MrChuw commented Feb 13, 2025

Yes, they are limiting the number of simultaneous requests to between 5 and 10 at a time.

I think it would be interesting to let the user control the delay between each request, obviously setting a minimum limit of, like, 1 second to avoid spamming the domain.

@Qolors
Copy link
Owner

Qolors commented Feb 20, 2025

This feature has been added with the release of v3.1.0 - please check there to see how to set up

Thanks for the request!

@Qolors Qolors closed this as completed Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants