Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all-fire context for conditional effects #20

Open
haz opened this issue Oct 8, 2024 · 1 comment
Open

Fix all-fire context for conditional effects #20

haz opened this issue Oct 8, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@haz
Copy link
Contributor

haz commented Oct 8, 2024

This code should be disabled for now, and then rethought: https://github.com/QuMuLab/pr2/blob/main/src/deadend.cc#L120

It's rarely used (requires a domain with conditional effects), and actually is buggy in the following situation:

(oneof
  (when (...) (...))
  (when (...) (...))
  ...
)

The all-fire context is computed for each determinized operator (unlike the conditional mask, which is computed for the full non-det operator), and it's only used for the regression of generalized deadends. It was a minor hack (unpublished) that let us gain a few more FSAPs in certain corner cases, and worked when the conditional effects were not nested within the oneof clauses. It's current implementation is incorrect when the condeffs are inside the oneof, as above -- result is an FSAP potentially being created that is too "strong" (rules out things it shouldn't).

@haz haz added bug Something isn't working help wanted Extra attention is needed labels Oct 8, 2024
@haz
Copy link
Contributor Author

haz commented Oct 8, 2024

Minimal broken example...

domain.pddl.txt
problem.pddl.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant