diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8f7a1f39b8cb4..608d2e40eef6d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -18,10 +18,17 @@ - [ ] I have added media to this PR or it does not require an in-game showcase. +## Licensing + +- [ ] I give permission for any changes to the repository made in this PR to be relicensed under MIT. + + **Changelog** +Changelog must have a :cl: symbol, so the bot recognizes the changes and adds them to the game's changelog. +The name that appears on the changelog will be your GitHub usernabe by default. If you wish for a different name to appear, format the symbol like so: +:cl: My Name --> + + diff --git a/Content.Client/Options/UI/OptionsMenu.xaml b/Content.Client/Options/UI/OptionsMenu.xaml index 568281089f047..21c4b64ce8fa0 100644 --- a/Content.Client/Options/UI/OptionsMenu.xaml +++ b/Content.Client/Options/UI/OptionsMenu.xaml @@ -1,8 +1,7 @@ + MinSize="800 450"> diff --git a/Content.Client/Options/UI/Tabs/AudioTab.xaml b/Content.Client/Options/UI/Tabs/AudioTab.xaml index 2929d5b260900..f5d57dbeb69ab 100644 --- a/Content.Client/Options/UI/Tabs/AudioTab.xaml +++ b/Content.Client/Options/UI/Tabs/AudioTab.xaml @@ -2,32 +2,49 @@ xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:ui="clr-namespace:Content.Client.Options.UI"> - - diff --git a/Content.Client/Options/UI/Tabs/AudioTab.xaml.cs b/Content.Client/Options/UI/Tabs/AudioTab.xaml.cs index 1f7df3a7992eb..e35412e8991a5 100644 --- a/Content.Client/Options/UI/Tabs/AudioTab.xaml.cs +++ b/Content.Client/Options/UI/Tabs/AudioTab.xaml.cs @@ -8,6 +8,7 @@ using Robust.Shared; using Robust.Shared.Configuration; using Content.Shared._EE.CCVar; // EE +using Content.Shared._VDS.CCVars; // VDS namespace Content.Client.Options.UI.Tabs; @@ -76,6 +77,17 @@ public AudioTab() Control.AddOptionCheckBox(CCVars.AdminSoundsEnabled, AdminSoundsCheckBox); Control.AddOptionCheckBox(CCVars.BwoinkSoundEnabled, BwoinkSoundCheckBox); + // VDS start + var acousticEnable = Control.AddOptionCheckBox(VCCVars.AcousticEnable, AcousticEnableCheckBox); + acousticEnable.ImmediateValueChanged += UpdateAcousticButtons; + Control.AddOptionCheckBox(VCCVars.AcousticHighResolution, AcousticHighResolutionCheckBox); + Control.AddOptionSlider( + VCCVars.AcousticReflectionCount, + SliderAcousticReflectionCount, + _cfg.GetCVar(VCCVars.AcousticReflectionCountMinimum), + _cfg.GetCVar(VCCVars.AcousticReflectionCountMaximum)); + // VDS end + Control.Initialize(); } @@ -84,6 +96,7 @@ protected override void EnteredTree() base.EnteredTree(); _admin.AdminStatusUpdated += UpdateAdminButtonsVisibility; UpdateAdminButtonsVisibility(); + UpdateAcousticButtons(_cfg.GetCVar(VCCVars.AcousticEnable)); // VDS } protected override void ExitedTree() @@ -98,6 +111,12 @@ private void UpdateAdminButtonsVisibility() BwoinkSoundCheckBox.Visible = _admin.IsActive(); } + private void UpdateAcousticButtons(bool value) // VDS + { + AcousticHighResolutionCheckBox.Visible = value is true; + SliderAcousticReflectionCount.Visible = value is true; + } + private void OnMasterVolumeSliderChanged(float value) { // TODO: I was thinking of giving OptionsTabControlRow a flag to "set CVar immediately", but I'm deferring that diff --git a/Content.Client/Options/UI/Tabs/MiscTab.xaml b/Content.Client/Options/UI/Tabs/MiscTab.xaml index c1733e209dbe7..92e426140e1c8 100644 --- a/Content.Client/Options/UI/Tabs/MiscTab.xaml +++ b/Content.Client/Options/UI/Tabs/MiscTab.xaml @@ -1,4 +1,4 @@ - diff --git a/Content.Client/Options/UI/Tabs/MiscTab.xaml.cs b/Content.Client/Options/UI/Tabs/MiscTab.xaml.cs index 79000af58c6d5..5217f1cb1b056 100644 --- a/Content.Client/Options/UI/Tabs/MiscTab.xaml.cs +++ b/Content.Client/Options/UI/Tabs/MiscTab.xaml.cs @@ -1,4 +1,4 @@ -using System.Linq; +using System.Linq; using Content.Client.UserInterface.Screens; using Content.Shared.CCVar; using Content.Shared.HUD; diff --git a/Content.Client/VendingMachines/UI/VendingMachineMenu.xaml b/Content.Client/VendingMachines/UI/VendingMachineMenu.xaml index 44b1ff95e7fea..5e51d9a88c3ec 100644 --- a/Content.Client/VendingMachines/UI/VendingMachineMenu.xaml +++ b/Content.Client/VendingMachines/UI/VendingMachineMenu.xaml @@ -7,6 +7,14 @@ + + +