Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily Reward analytics are not sent to Hypixel's GA #97

Open
robere2 opened this issue Aug 18, 2019 · 2 comments
Open

Daily Reward analytics are not sent to Hypixel's GA #97

robere2 opened this issue Aug 18, 2019 · 2 comments
Labels
Priority: LOW This issue is of low priority. Scope: Premium This issue applies specifically to Quickplay Premium. Scope: Socket This issue applies specifically to Quickplay's backend systems. Status: In progress At least one commit has been made towards this issue, however it's not yet ready for review/merge. Type: Bug This issue contains a bug.

Comments

@robere2
Copy link
Collaborator

robere2 commented Aug 18, 2019

This was removed in 1.0.3 due to a crunch for time. Fortunately, it can be added to the backend at any time without a client mod update. Only downside is this would show all analytics coming from the same location, however due to how small of a sample size it is, I think this is okay.
@robere2 robere2 added Type: Bug This issue contains a bug. Priority: LOW This issue is of low priority. Scope: Premium This issue applies specifically to Quickplay Premium. Scope: Socket This issue applies specifically to Quickplay's backend systems. labels Aug 18, 2019
@robere2 robere2 added this to the 2.1.0 milestone Jul 23, 2020
@robere2
Copy link
Collaborator Author

robere2 commented Jul 23, 2020

It might not be a bad idea to add the analytics to the client code. This should be an easy modification, as the code from pre-1.0.3 can be used, and it means the analytics will contain the correct location.

@robere2 robere2 removed this from the 2.1.0 milestone Sep 10, 2020
@robere2 robere2 added Status: Todo This issue has been approved and needs to be completed/implemented. Status: In progress At least one commit has been made towards this issue, however it's not yet ready for review/merge. and removed Status: Todo This issue has been approved and needs to be completed/implemented. labels Dec 25, 2020
@robere2
Copy link
Collaborator Author

robere2 commented Dec 25, 2020

2.1.0's client protocol now supports sending/receiving Google Analytics tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: LOW This issue is of low priority. Scope: Premium This issue applies specifically to Quickplay Premium. Scope: Socket This issue applies specifically to Quickplay's backend systems. Status: In progress At least one commit has been made towards this issue, however it's not yet ready for review/merge. Type: Bug This issue contains a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robere2