Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch final method override errors in dropInvalidMappings #244

Open
ix0rai opened this issue Dec 6, 2024 · 0 comments
Open

catch final method override errors in dropInvalidMappings #244

ix0rai opened this issue Dec 6, 2024 · 0 comments
Labels
backend affects the enigma backend enhancement New feature or request p: low low priority

Comments

@ix0rai
Copy link
Member

ix0rai commented Dec 6, 2024

it's possible, through renames or matching, that a method ends up mistakenly overriding a final method. this, of course, causes errors in production!

we should implement a catch for this in dropInvalidMappings, likely in a new step (currently existing steps are checking for mappings that don't exist in the jar, then checking for empty mappings) and possibly also on rename.

@ix0rai ix0rai added enhancement New feature or request backend affects the enigma backend p: low low priority labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend affects the enigma backend enhancement New feature or request p: low low priority
Projects
None yet
Development

No branches or pull requests

1 participant