Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for downloading models #14

Open
nalf3in opened this issue Oct 25, 2023 · 2 comments
Open

Improvements for downloading models #14

nalf3in opened this issue Oct 25, 2023 · 2 comments

Comments

@nalf3in
Copy link

nalf3in commented Oct 25, 2023

Hey there, just wanted to discuss about potentials improvement for downloading the models.

For my integration of your tts in homeassistant wyoming-glados I created a script that downloads the models for this repo here. Instead of google drive it uses github releases which allows unlimited downloads. Also getting the project running would be a bit easier for users as they would only have to

git clone https://github.com/R2D2FISH/glados-tts/
cd glados-tts
python3 download.py

Instead of manually downloading and moving the files from google drive.

I would be happy to submit a pr including the script and adjustments to the readme if these changes are welcome. You would need create a github release for this repo and add the model files like here though.

@R2D2FISH
Copy link
Owner

Awesome! Go ahead. I never expected to get so much support from random people on the internet on this project but its nice because I'm pretty busy with classes and stuff.

@nalf3in
Copy link
Author

nalf3in commented Oct 27, 2023

Perfect ! I will submit a pr next time I have some free time. If you can create a release with the model files like here I will edit the hardcoded URL in download.py to your repo instead of mine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants