Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate react classes to use the latest hooks #29

Open
RAJAGOPALAN-GANGADHARAN opened this issue Feb 6, 2021 · 6 comments
Open

Migrate react classes to use the latest hooks #29

RAJAGOPALAN-GANGADHARAN opened this issue Feb 6, 2021 · 6 comments
Assignees
Labels
crossWoc Crosswoc-official-issue difficulty: hard Issues tagged as hard

Comments

@RAJAGOPALAN-GANGADHARAN
Copy link
Owner

Either migrating one class at a time(All the essential window wrappers and then the pre installed applications) or Migrating it all at once, Whichever method works fine.

@RAJAGOPALAN-GANGADHARAN RAJAGOPALAN-GANGADHARAN added crossWoc Crosswoc-official-issue difficulty: hard Issues tagged as hard labels Feb 11, 2021
@abhinav5481
Copy link

Hi,
I would like to work on this issue. Could you please assign it to me?

@RAJAGOPALAN-GANGADHARAN
Copy link
Owner Author

Hey @abhinav5481 , Good luck. Ping me if you need any help.

@shmiitg
Copy link

shmiitg commented Dec 10, 2021

I would like to work on this. Just one doubt: Do I need to change every file with class components to hooks or some specific files only?

@RAJAGOPALAN-GANGADHARAN
Copy link
Owner Author

Hello @shmiitg , Thank you for your interest in this - we have to migrate every class from classes to hooks but we could do it one by one. Starting from non impacted defaultapps like say minesweeper etc

@shmiitg
Copy link

shmiitg commented Dec 11, 2021

Ok sir, I got it. I will start working on this. You can assign me this issue.

@shmiitg
Copy link

shmiitg commented Dec 11, 2021

Sir i have changed the following files:
calender.js
codestudio.js
menubar.js
minesweeper
markdown_editor.js
markdown_reader.js
pdf.js
processmanager.js

I am sending a pr, if you dont find any mistakes you can merge it, I will slowly and gradually change all the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crossWoc Crosswoc-official-issue difficulty: hard Issues tagged as hard
Projects
None yet
Development

No branches or pull requests

3 participants