Skip to content

Commit c267dcb

Browse files
authored
ROCm - 6.4 updates (#1466)
* ROCm - 6.4 updates * Readme - cleanup * Setup - Updates * Docs - Updates
1 parent d5d6bb7 commit c267dcb

File tree

8 files changed

+64
-72
lines changed

8 files changed

+64
-72
lines changed

CHANGELOG.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,13 @@ The full documentation for MIVisionX is available at [https://rocm.docs.amd.com/
2828
* Setup: rocdecode install disabled
2929
* Package: rocdecode dependency removed
3030

31+
### Optimizations
32+
33+
* Setup: only core dependency packages installed
34+
3135
### Known issues
3236

33-
* Package installation requires the manual installation of OpenCV.
34-
* Installation on CentOS/RedHat/SLES requires the manual installation of the `FFMPEG Dev` package.
35-
* Hardware decode requires the ROCm `graphics` usecase.
37+
* MIVisionX package installation on RedHat/SLES requires the manual installation of the `OpenCV` and `FFMPEG` development package.
3638

3739
### Upcoming changes
3840

@@ -66,7 +68,7 @@ The full documentation for MIVisionX is available at [https://rocm.docs.amd.com/
6668
### Known issues
6769

6870
* Package install requires manually installing OpenCV
69-
* Installationon CentOS/RedHat/SLES requires manually installing the `FFMPEG Dev` package
71+
* Installation CentOS/RedHat/SLES requires manually installing the `FFMPEG Dev` package
7072
* Hardware decode requires the ROCm `graphics` usecase.
7173

7274
### Upcoming changes

CMakeLists.txt

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -230,19 +230,17 @@ endif()
230230
set(MIVISIONX_RUNTIME_PACKAGE_LIST "rocm-hip-runtime, rpp, rocblas, miopen-hip, migraphx")
231231

232232
# Set the dev dependent packages
233-
set(MIVISIONX_DEBIAN_DEV_PACKAGE_LIST "half, rocm-hip-runtime-dev, rpp-dev, rocblas-dev, miopen-hip-dev, migraphx-dev, libavcodec-dev, libavformat-dev, libavutil-dev, libswscale-dev, libopencv-dev")
234-
# TBD - Some RPM packages need Fusion Packages - ffmpeg, libavcodec-devel, libavformat-devel, libavutil-devel, libswscale-devel, libopencv
235-
set(MIVISIONX_RPM_DEV_PACKAGE_LIST "half, rocm-hip-runtime-devel, rpp-devel, rocblas-devel, miopen-hip-devel, migraphx-devel")
233+
set(MIVISIONX_DEBIAN_DEV_PACKAGE_LIST "half, rocm-hip-runtime-dev, rpp-dev, rocblas-dev, miopen-hip-dev, migraphx-dev, pkg-config, libavcodec-dev, libavformat-dev, libavutil-dev, libswscale-dev, libopencv-dev, libomp-dev")
234+
# TBD - Some RPM packages need Fusion Packages - libavcodec-devel, libavformat-devel, libavutil-devel, libswscale-devel, libopencv
235+
set(MIVISIONX_RPM_DEV_PACKAGE_LIST "half, rocm-hip-runtime-devel, rpp-devel, rocblas-devel, miopen-hip-devel, migraphx-devel, pkg-config, libomp-devel")
236236

237-
# Add rocDecode Deps - Exclude centos-7
238-
if (EXISTS "/etc/os-release")
237+
# Add OS specific dependencies
238+
if(EXISTS "/etc/os-release")
239239
file(READ "/etc/os-release" OS_RELEASE)
240-
string(REGEX MATCH "CentOS-7" CENTOS_7_FOUND ${OS_RELEASE})
241-
#if(NOT CENTOS_7_FOUND) - Disable TBD: Turn on with package update
242-
#set(MIVISIONX_RUNTIME_PACKAGE_LIST "${MIVISIONX_RUNTIME_PACKAGE_LIST}, rocdecode")
243-
#set(MIVISIONX_DEBIAN_DEV_PACKAGE_LIST "${MIVISIONX_DEBIAN_DEV_PACKAGE_LIST}, rocdecode-dev")
244-
#set(MIVISIONX_RPM_DEV_PACKAGE_LIST "${MIVISIONX_RPM_DEV_PACKAGE_LIST}, rocdecode-devel")
245-
#endif()
240+
string(REGEX MATCH "22.04" UBUNTU_22_FOUND ${OS_RELEASE})
241+
if(UBUNTU_22_FOUND)
242+
set(MIVISIONX_DEBIAN_DEV_PACKAGE_LIST "${MIVISIONX_DEBIAN_DEV_PACKAGE_LIST}, libstdc++-12-dev")
243+
endif()
246244
endif()
247245

248246
# '%{?dist}' breaks manual builds on debian systems due to empty Provides

MIVisionX-setup.py

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
__copyright__ = "Copyright 2018 - 2024, AMD ROCm MIVisionX"
3232
__license__ = "MIT"
33-
__version__ = "3.8.0"
33+
__version__ = "3.8.1"
3434
__email__ = "[email protected]"
3535
__status__ = "Shipping"
3636

@@ -250,9 +250,7 @@ def ERROR_CHECK(waitval):
250250

251251
inferenceDebianPackages = [
252252
'python3-dev',
253-
'python3-pip',
254-
'protobuf-compiler',
255-
'libprotoc-dev'
253+
'python3-pip'
256254
]
257255

258256
neuralNetRPMPackages = [
@@ -262,14 +260,9 @@ def ERROR_CHECK(waitval):
262260
'migraphx-devel'
263261
]
264262

265-
libPythonProto = "python3-protobuf"
266-
if "centos" in os_info_data and "VERSION_ID=7" in os_info_data:
267-
libPythonProto = "protobuf-python"
268263
inferenceRPMPackages = [
269264
'python3-devel',
270-
'python3-pip',
271-
'protobuf-devel',
272-
str(libPythonProto)
265+
'python3-pip'
273266
]
274267

275268
pipNumpyVersion = "numpy==1.23.0"
@@ -311,7 +304,6 @@ def ERROR_CHECK(waitval):
311304
]
312305

313306
ffmpegDebianPackages = [
314-
'ffmpeg',
315307
'libavcodec-dev',
316308
'libavformat-dev',
317309
'libavutil-dev',
@@ -347,8 +339,7 @@ def ERROR_CHECK(waitval):
347339
'libjpeg-devel',
348340
'libpng-devel',
349341
'libtiff-devel',
350-
'libavc1394',
351-
'unzip'
342+
'libavc1394'
352343
]
353344

354345
# update
@@ -456,14 +447,15 @@ def ERROR_CHECK(waitval):
456447
# Install base Deps
457448
for i in range(len(pip3InferencePackagesRPM)):
458449
ERROR_CHECK(os.system('pip3 install '+ pip3InferencePackagesRPM[i]))
459-
if "SLES" in platfromInfo or "Mariner" in platfromInfo or "redhat-8" in platfromInfo:
460-
ERROR_CHECK(os.system('mkdir -p '+modelCompilerDeps+'/nnef-deps'))
461-
ERROR_CHECK(os.system(
462-
'(cd '+modelCompilerDeps+'/nnef-deps; git clone -b nnef-v1.0.0 https://github.com/KhronosGroup/NNEF-Tools.git)'))
463-
ERROR_CHECK(os.system(
464-
'(cd '+modelCompilerDeps+'/nnef-deps/NNEF-Tools/parser/cpp; mkdir -p build && cd build; '+linuxCMake+' ..; make -j$(nproc); sudo make install)'))
465-
ERROR_CHECK(os.system(
466-
'(cd '+modelCompilerDeps+'/nnef-deps/NNEF-Tools/parser/python; sudo python3 setup.py install)'))
450+
# NNEF Manual Install
451+
if "SLES" in platfromInfo or "Mariner" in platfromInfo or "redhat-8" in platfromInfo:
452+
ERROR_CHECK(os.system('mkdir -p '+modelCompilerDeps+'/nnef-deps'))
453+
ERROR_CHECK(os.system(
454+
'(cd '+modelCompilerDeps+'/nnef-deps; git clone -b nnef-v1.0.0 https://github.com/KhronosGroup/NNEF-Tools.git)'))
455+
ERROR_CHECK(os.system(
456+
'(cd '+modelCompilerDeps+'/nnef-deps/NNEF-Tools/parser/cpp; mkdir -p build && cd build; '+linuxCMake+' ..; make -j$(nproc); sudo make install)'))
457+
ERROR_CHECK(os.system(
458+
'(cd '+modelCompilerDeps+'/nnef-deps/NNEF-Tools/parser/python; sudo python3 setup.py install)'))
467459
else:
468460
print("STATUS: Model Compiler Deps Pre-Installed - " +modelCompilerDeps+"\n")
469461
else:

0 commit comments

Comments
 (0)