Skip to content

Commit 8cd8ef1

Browse files
authored
[doc] Warn about Python install dirs containing spaces on Windows. (#1192)
Follow-up to #1190. Related to #910. I'm also considering adding a check to https://github.com/ROCm/TheRock/blob/main/build_tools/hack/build_env_diag.py.
1 parent f1b202c commit 8cd8ef1

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

docs/development/windows_support.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,11 @@ If you prefer to install tools manually, you will need:
156156
157157
- Python: https://www.python.org/downloads/ (3.11+ recommended)
158158
159+
> [!WARNING]
160+
> Prefer to install Python for the current user only and to a path
161+
> **without spaces** like
162+
> `C:\Users\<username>\AppData\Local\Programs\Python\Python312`.
163+
159164
- Strawberry Perl, which comes with gfortran: https://strawberryperl.com/
160165
161166
#### Important tool settings

external-builds/pytorch/README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,14 @@ and [Python Packaging](../../docs/packaging/python_packaging.md) documentation
4242
for more background on these `rocm` packages.
4343

4444
> [!WARNING]
45-
> Windows support for these packages is _very_ new so some instructions
46-
> may not work yet. Stay tuned!
45+
> On Windows, prefer to install Python for the current user only and to a path
46+
> **without spaces** like
47+
> `C:\Users\<username>\AppData\Local\Programs\Python\Python312`.
48+
>
49+
> Several developers have reported issues building torchvision when using
50+
> "Install Python for all users" with a default path like
51+
> `C:\Program Files\Python312` (note the space in "Program Files"). See
52+
> https://github.com/pytorch/vision/issues/9165 for details.
4753
4854
### Quickstart
4955

0 commit comments

Comments
 (0)