Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP build failing with hiprtc related error. #23 (CONT-D) #39

Closed
jdgh000 opened this issue Dec 13, 2023 · 3 comments
Closed

HIP build failing with hiprtc related error. #23 (CONT-D) #39

jdgh000 opened this issue Dec 13, 2023 · 3 comments

Comments

@jdgh000
Copy link

jdgh000 commented Dec 13, 2023

THis is continued from following which closed without confirmation: HIP build failing with hiprtc related error. #23
First I want to ask why are you closing without even confirming with me that build works? Build is still failing, please do not close because I cant re-open!!!

Your last post here absolutely makes no sense:
the idea here is, there are two repo you need to build HIP on AMD platforms (there are several but for our purpose we can ignore them).
As I said clr was not building due to hiprtc related error. Are you saying checkout hip and clr, which one to build first?
IF i build clr, it fails with same reason.

It starts with which version of ROCm you have installed.
you can figure it out by doing a cat /opt/rocm/.info/version-dev

You will get a number 5.6 or 5.7

After that you need to checkout the repo
https://github.com/ROCm-Developer-Tools/clr
https://github.com/ROCm-Developer-Tools/hip
to rocm-5.n whatever your ROCm version was installed and then try to build it.

Here clr and hip version needs to match




@schung-amd
Copy link

Hi @jdgh000, sorry for the wait and that this was closed on you. Are you still experiencing this issue?

@schung-amd
Copy link

I can't reproduce this on ROCm 6.2. Not sure if this was a versioning issue as noted, or if something has changed since this issue was current. I was able to build clr (and HIP as a prerequisite) following the instructions at https://rocm.docs.amd.com/projects/HIP/en/develop/install/build.html followed by the instructions to build clr in https://github.com/ROCm/clr/blob/amd-staging/README.md.

To clarify what the post you quoted is saying, these two repos have different branches corresponding to different versions of ROCm, so you have to make sure to pull the correct branch for your version of ROCm, as noted in the HIP guide. If you pull branches whose versions do not match, this can cause issues like those you have seen.

The HIP guide involves pulling both the HIP and clr repos and building HIP. Afterward, follow the clr guide, which says at one point

For HIP:
cmake .. -DCLR_BUILD_HIP=ON -DHIP_COMMON_DIR=$HIP_COMMON_DIR

HIP_COMMON_DIR points to [HIP](https://github.com/ROCm/HIP)

Replace HIP_COMMON_DIR here with the location that HIP was built to, and you should be able to build clr.

The clr and HIP guides also point to guidance on building hip-tests to test the functionality of your installation. Note that the hip-tests repo also has branches corresponding to ROCm version, and if you pull the wrong branch you will likely see failing tests.

I'll close the other issue and leave this one open for now, in case you have any further questions about building HIP and clr. Also, in the future, if we close an issue and you feel it is unresolved, comment on the issue and we can reopen it. You are free to resubmit the issue (as you did here) if you prefer, but it is more convenient to have all the information in one place.

@schung-amd
Copy link

Closing this here as well for now. As mentioned, feel free to comment on this issue if you'd like it reopened, or you can submit a new issue.

@schung-amd schung-amd closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants