Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMD_PLATFORM_BUILD_NUMBER #68

Closed
preda opened this issue Mar 22, 2024 · 1 comment
Closed

Update AMD_PLATFORM_BUILD_NUMBER #68

preda opened this issue Mar 22, 2024 · 1 comment

Comments

@preda
Copy link

preda commented Mar 22, 2024

In rocclr/utils/versions.hpp there is:

#define AMD_PLATFORM_BUILD_NUMBER 3581

#define AMD_PLATFORM_BUILD_NUMBER 3581

Which was last updated in March 2023 (one year ago).

But the same value for ROCm 6.1RC is 3614 ATM.

Please keep this public repo in sync with the ROCm that is released and with the ROCm RC.

This version number is useful to track which changes are where. I don't understand how the version here in the public repo was not updated for a year? while there are ongoing commits to this public repo. Is this a problem with the version number being out-of-sync, or is the situation that changes to CLR since one year ago didn't make it here in the open yet?

@mangupta
Copy link
Contributor

@preda : We update the version when we merge changes from our development branch (amd-staging) to mainline branch (amd-mainline). The commit you are looking at is in the development branch in which we do not bump this version. Please refer to https://github.com/ROCm/clr/blob/amd-mainline/rocclr/utils/versions.hpp#L31 where you can see that the version is being regularly updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants