Skip to content

Commit 4020351

Browse files
committed
Address review comments: clang format and ckProfiler typo
1 parent 32eb4f2 commit 4020351

File tree

6 files changed

+53
-50
lines changed

6 files changed

+53
-50
lines changed

profiler/include/profiler/profile_gemm_blockscale_wp_impl.hpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -69,19 +69,19 @@ template <typename A0DataType,
6969
typename ALayout,
7070
typename BLayout,
7171
typename ELayout>
72-
bool profile_gemm_blockscale_weighpreshuffle_impl(int do_verification,
73-
int init_method,
74-
bool do_log,
75-
bool time_kernel,
76-
int M,
77-
int N,
78-
int K,
79-
int StrideA,
80-
int StrideB,
81-
int StrideE,
82-
int n_warmup,
83-
int n_iter,
84-
uint64_t rotating = 0)
72+
bool profile_gemm_blockscale_weightpreshuffle_impl(int do_verification,
73+
int init_method,
74+
bool do_log,
75+
bool time_kernel,
76+
int M,
77+
int N,
78+
int K,
79+
int StrideA,
80+
int StrideB,
81+
int StrideE,
82+
int n_warmup,
83+
int n_iter,
84+
uint64_t rotating = 0)
8585
{
8686
bool pass = true;
8787

profiler/src/profile_gemm_blockscale_wp.cpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -126,19 +126,19 @@ int profile_gemm_blockscale_weighpreshuffle(int argc, char* argv[])
126126
const int DefaultStrideB = ck::is_same_v<BLayout, Row> ? N : K;
127127
const int DefaultStrideE = ck::is_same_v<ELayout, Row> ? N : M;
128128

129-
bool pass = ck::profiler::profile_gemm_blockscale_weighpreshuffle_impl<A0DataType,
130-
A1DataType,
131-
B0DataType,
132-
B1DataType,
133-
ComputeDataType,
134-
AccDataType,
135-
EDataType,
136-
scale_block_m,
137-
scale_block_n,
138-
scale_block_k,
139-
ALayout,
140-
BLayout,
141-
ELayout>(
129+
bool pass = ck::profiler::profile_gemm_blockscale_weightpreshuffle_impl<A0DataType,
130+
A1DataType,
131+
B0DataType,
132+
B1DataType,
133+
ComputeDataType,
134+
AccDataType,
135+
EDataType,
136+
scale_block_m,
137+
scale_block_n,
138+
scale_block_k,
139+
ALayout,
140+
BLayout,
141+
ELayout>(
142142
do_verification,
143143
init_method,
144144
do_log,

test/gemm_blockscale_wp/test_gemm_blockscale_wp_xdl_fp8.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ using KernelTypes_MK_NK = ::testing::Types<
3939
std::tuple< F8, F32, F8, F32, F8, BF16>
4040
#endif
4141
>;
42+
// clang-format on
4243

4344
TYPED_TEST_SUITE(TestGemmBlockScaleWP_FP8_MK_NK, KernelTypes_MK_NK);
4445

test/gemm_blockscale_wp/test_gemm_common.hpp

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -44,30 +44,30 @@ class TestGemmBlockscaleWPCommon : public ::testing::Test
4444

4545
all_success =
4646
all_success &
47-
ck::profiler::profile_gemm_blockscale_weighpreshuffle_impl<A0DataType,
48-
A1DataType,
49-
B0DataType,
50-
B1DataType,
51-
ComputeDataType,
52-
F32,
53-
CDataType,
54-
ScaleBlockM,
55-
ScaleBlockN,
56-
ScaleBlockK,
57-
ALayout,
58-
BLayout,
59-
CLayout>(verify_,
60-
init_method_,
61-
log_,
62-
bench_,
63-
M,
64-
N,
65-
K,
66-
StrideA,
67-
StrideB,
68-
StrideC,
69-
n_warmup,
70-
n_iter);
47+
ck::profiler::profile_gemm_blockscale_weightpreshuffle_impl<A0DataType,
48+
A1DataType,
49+
B0DataType,
50+
B1DataType,
51+
ComputeDataType,
52+
F32,
53+
CDataType,
54+
ScaleBlockM,
55+
ScaleBlockN,
56+
ScaleBlockK,
57+
ALayout,
58+
BLayout,
59+
CLayout>(verify_,
60+
init_method_,
61+
log_,
62+
bench_,
63+
M,
64+
N,
65+
K,
66+
StrideA,
67+
StrideB,
68+
StrideC,
69+
n_warmup,
70+
n_iter);
7171

7272
EXPECT_TRUE(all_success);
7373
}

test/gemm_multiply_multiply_wp/test_gemm_multiply_multiply_wp_xdl_fp8.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ using KernelTypes_MK_NK = ::testing::Types<
4242
std::tuple< F8, F8, F8, F32, F32, BF16>
4343
#endif
4444
>;
45+
// clang-format on
4546

4647
TYPED_TEST_SUITE(TestGemmMultiplyMultiplyWP_FP8_MK_NK, KernelTypes_MK_NK);
4748

test/gemm_universal_preshuffle/test_gemm_universal_preshuffle_xdl_fp8.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ using KernelTypes_MK_NK = ::testing::Types<
4242
std::tuple< F8, F8, F8, BF16>
4343
#endif
4444
>;
45+
// clang-format on
4546

4647
TYPED_TEST_SUITE(TestGemmUniversalPreshuffle_FP8_MK_NK, KernelTypes_MK_NK);
4748

0 commit comments

Comments
 (0)