Skip to content

Conversation

@EnricoDeg
Copy link
Contributor

@EnricoDeg EnricoDeg commented Oct 31, 2025

Proposed changes

Summary:

  • Fix splitk for gemm_multiply_multiply_wp and gemm_universal_b_preshuffle
  • Add tests for gemm_multiply_multiply_wp, gemm_universal_b_preshuffle and gemm_blockscale_wp (does not support splitk)
  • Fix conditions for supported arguments in gemm_universal_b_preshuffle based on gemm_multiply_multiply_wp
  • Fix tolerances in profiler for gemm_multiply_multiply_wp and gemm_universal_b_preshuffle (in order to work with splitK and large K)
  • Fix strides in profiler for gemm_multiply_multiply_wp, gemm_universal_b_preshuffle and gemm_blockscale_wp

Explanation for splitK fix: for matrix B (preshuffled) it is not possible to shift the pointers, so in this case the same approach used for convolution is applied. The grid descriptor is shifted.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants