Add basic support for GPUs that can be partitioned

Author: y2kenny-amd

cmd/k8s-device-plugin/main.go

@@ -128,6 +128,8 @@ func (p *Plugin) PreStartContainer(ctx context.Context, r *pluginapi.PreStartCon
 func (p *Plugin) ListAndWatch(e *pluginapi.Empty, s pluginapi.DevicePlugin_ListAndWatchServer) error {
 	p.AMDGPUs = amdgpu.GetAMDGPUs()
 
+	glog.Infof("Found %d AMDGPUs", len(p.AMDGPUs))
+
 	devs := make([]*pluginapi.Device, len(p.AMDGPUs))
 
 	// limit scope for hwloc

internal/pkg/amdgpu/amdgpu.go

@@ -95,21 +95,52 @@ func GetAMDGPUs() map[string]map[string]int {
 	matches, _ := filepath.Glob("/sys/module/amdgpu/drivers/pci:amdgpu/[0-9a-fA-F][0-9a-fA-F][0-9a-fA-F][0-9a-fA-F]:*")
 
 	devices := make(map[string]map[string]int)
+	card, renderD := 0, 128
 
 	for _, path := range matches {
 		glog.Info(path)
 		devPaths, _ := filepath.Glob(path + "/drm/*")
-		devices[filepath.Base(path)] = make(map[string]int)
 
 		for _, devPath := range devPaths {
 			switch name := filepath.Base(devPath); {
 			case name[0:4] == "card":
-				devices[filepath.Base(path)][name[0:4]], _ = strconv.Atoi(name[4:])
+				card, _ = strconv.Atoi(name[4:])
 			case name[0:7] == "renderD":
-				devices[filepath.Base(path)][name[0:7]], _ = strconv.Atoi(name[7:])
+				renderD, _ = strconv.Atoi(name[7:])
 			}
 		}
+
+		devices[filepath.Base(path)] = map[string]int{"card": card, "renderD": renderD}
+	}
+
+	// certain products have additional devices (such as MI300's partitions)
+	//ex: /sys/devices/platform/amdgpu_xcp_30
+	platformMatches, _ := filepath.Glob("/sys/devices/platform/amdgpu_xcp_*")
+
+	// This is needed because some of the visible renderD are actually not valid
+	// Their validity depends on topology information from KFD
+        topoRenderNodes := renderNodeSetFromTopology()
+
+	for _, path := range platformMatches {
+		glog.Info(path)
+		devPaths, _ := filepath.Glob(path + "/drm/*")
+
+		for _, devPath := range devPaths {
+			switch name := filepath.Base(devPath); {
+			case name[0:4] == "card":
+				card, _ = strconv.Atoi(name[4:])
+			case name[0:7] == "renderD":
+				renderD, _ = strconv.Atoi(name[7:])
+			}
+		}
+
+		if !topoRenderNodes[renderD] {
+			continue
+		}
+
+		devices[filepath.Base(path)] = map[string]int{"card": card, "renderD": renderD}
 	}
+
 	return devices
 }
 
@@ -274,3 +305,38 @@ func parseDebugFSFirmwareInfo(path string) (map[string]uint32, map[string]uint32
 
 	return feat, fw
 }
+
+var topoDrmRenderMinorRe = regexp.MustCompile(`drm_render_minor\s(\d+)`)
+
+func renderNodeSetFromTopology(topoRootParam ...string) map[int]bool {
+	topoRoot := "/sys/class/kfd/kfd"
+	if len(topoRootParam) == 1 {
+		topoRoot = topoRootParam[0]
+	}
+
+	renderNodes := make(map[int]bool)
+	var nodeFiles []string
+	var err error
+
+	if nodeFiles, err = filepath.Glob(topoRoot + "/topology/nodes/*/properties"); err != nil {
+		glog.Fatalf("glob error: %s", err)
+		return renderNodes
+	}
+
+	for _, nodeFile := range nodeFiles {
+		glog.Info("Parsing " + nodeFile)
+		v, e := ParseTopologyProperties(nodeFile, topoDrmRenderMinorRe)
+		if e != nil {
+			glog.Error(e)
+			continue
+		}
+
+		if v <= 0 {
+			continue
+		}
+
+		renderNodes[int(v)] = true
+	}
+
+	return renderNodes
+}

internal/pkg/amdgpu/amdgpu_test.go

@@ -17,9 +17,11 @@
 package amdgpu
 
 import (
+	"encoding/json"
 	"fmt"
 	"io/ioutil"
 	"path/filepath"
+	"reflect"
 	"regexp"
 	"strings"
 	"testing"
@@ -213,3 +215,17 @@ func TestParseDebugFSFirmwareInfo(t *testing.T) {
 		t.Errorf("Incorrect parsing of amdgpu firmware info from debugfs")
 	}
 }
+
+func TestRenderNodeSetFromTopology(t *testing.T) {
+	renderNodes := renderNodeSetFromTopology("../../../testdata/topology-parsing-mi308")
+
+	expNodes := map[int]bool{128: true, 129: true}
+	if !reflect.DeepEqual(renderNodes, expNodes) {
+		val, _ := json.MarshalIndent(renderNodes, "", "  ")
+		exp, _ := json.MarshalIndent(expNodes, "", "  ")
+
+		t.Errorf("RenderNode set was incorrect")
+		t.Errorf("Got: %s", val)
+		t.Errorf("Want: %s", exp)
+	}
+}

testdata/topology-parsing-mi308/topology/generation_id

@@ -0,0 +1 @@
+33

testdata/topology-parsing-mi308/topology/nodes/0/gpu_id

@@ -0,0 +1 @@
+0

testdata/topology-parsing-mi308/topology/nodes/0/io_links/0/properties

@@ -0,0 +1,12 @@
+type 5
+version_major 0
+version_minor 0
+node_from 0
+node_to 1
+weight 21
+min_latency 0
+max_latency 0
+min_bandwidth 0
+max_bandwidth 0
+recommended_transfer_size 0
+flags 0

testdata/topology-parsing-mi308/topology/nodes/0/io_links/1/properties

@@ -0,0 +1,12 @@
+type 2
+version_major 0
+version_minor 0
+node_from 0
+node_to 2
+weight 20
+min_latency 0
+max_latency 0
+min_bandwidth 312
+max_bandwidth 64000
+recommended_transfer_size 0
+flags 3

testdata/topology-parsing-mi308/topology/nodes/0/io_links/10/properties

@@ -0,0 +1,12 @@
+type 2
+version_major 0
+version_minor 0
+node_from 0
+node_to 11
+weight 20
+min_latency 0
+max_latency 0
+min_bandwidth 312
+max_bandwidth 64000
+recommended_transfer_size 0
+flags 3

testdata/topology-parsing-mi308/topology/nodes/0/io_links/11/properties

@@ -0,0 +1,12 @@
+type 2
+version_major 0
+version_minor 0
+node_from 0
+node_to 12
+weight 20
+min_latency 0
+max_latency 0
+min_bandwidth 312
+max_bandwidth 64000
+recommended_transfer_size 0
+flags 3

testdata/topology-parsing-mi308/topology/nodes/0/io_links/12/properties

@@ -0,0 +1,12 @@
+type 2
+version_major 0
+version_minor 0
+node_from 0
+node_to 13
+weight 20
+min_latency 0
+max_latency 0
+min_bandwidth 312
+max_bandwidth 64000
+recommended_transfer_size 0
+flags 3