plan: check multiple devices in rank correctly for global transpose (#1429)

[ROCm/rocFFT commit: f899388]

Author: evetsso

projects/rocfft/library/src/include/plan.h

@@ -172,10 +172,9 @@ struct rocfft_plan_description_t
         return fieldPtrs;
     }
 
-    // returns true if a field:
-    // - has bricks across multiple ranks (i.e. MPI), and
-    // - any rank has bricks on more than one device
-    static bool multiple_ranks_devices(const rocfft_field_t& field);
+    // returns true if a field has bricks such that any rank has
+    // bricks on more than one device
+    static bool multiple_devices_in_rank(const rocfft_field_t& field);
 };
 
 struct rocfft_plan_t

projects/rocfft/library/src/plan.cpp

@@ -196,7 +196,7 @@ void rocfft_plan_description_t::init_defaults(rocfft_transform_type      transfo
     }
 }
 
-bool rocfft_plan_description_t::multiple_ranks_devices(const rocfft_field_t& field)
+bool rocfft_plan_description_t::multiple_devices_in_rank(const rocfft_field_t& field)
 {
     // map ranks to a set of distinct devices
     std::map<int, std::set<int>> rank_devices;
@@ -208,10 +208,6 @@ bool rocfft_plan_description_t::multiple_ranks_devices(const rocfft_field_t& fie
         devices.insert(brick.location.device);
     }
 
-    // need to have multiple ranks to return true
-    if(rank_devices.size() <= 1)
-        return false;
-
     // any rank needs to have multiple devices to return true
     for(const auto& rank_device : rank_devices)
     {
@@ -1924,8 +1920,8 @@ void rocfft_plan_t::GlobalTranspose(size_t                     elem_size,
     // Fall back to point-to-point transfers if all-to-all is not
     // possible.
     std::string itemGroup = "transpose_" + std::to_string(transposeNumber);
-    if(rocfft_plan_description_t::multiple_ranks_devices(inField)
-       || rocfft_plan_description_t::multiple_ranks_devices(outField))
+    if(rocfft_plan_description_t::multiple_devices_in_rank(inField)
+       || rocfft_plan_description_t::multiple_devices_in_rank(outField))
         GlobalTransposeP2P(
             elem_size, inField, outField, input, output, inputAntecedents, outputItems, itemGroup);
     else