fix(rocsparse): Fix SpMM batching with CSR rowsplit algorithm when batch count >65536#9933
Open
jsandham wants to merge 4 commits into
Open
fix(rocsparse): Fix SpMM batching with CSR rowsplit algorithm when batch count >65536#9933jsandham wants to merge 4 commits into
jsandham wants to merge 4 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9933 +/- ##
========================================
Coverage 69.56% 69.56%
========================================
Files 2770 2770
Lines 452498 452516 +18
Branches 66620 66620
========================================
+ Hits 314760 314778 +18
Misses 117292 117292
Partials 20446 20446
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
jsandham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we use the y grid dimension to perform batch computation with SpMM row-split algorithm. This means that if the number of batches exceeds 65536 we will get launch errors. This PR fixes that by looping over the batch count in blocks of 65536 batches.
JIRA ID: AISPARSE-605