Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu isn't fullscreen when docked #21

Open
vitormmatos opened this issue Jun 9, 2018 · 10 comments
Open

Menu isn't fullscreen when docked #21

vitormmatos opened this issue Jun 9, 2018 · 10 comments

Comments

@vitormmatos
Copy link

When docked the menu becomes little, close to a quarter of the screen, on top left.
Still the A, B and X labels still appear on right bottom of TV, but with no text, where there is just a black background.

@dene-
Copy link
Contributor

dene- commented Jun 9, 2018

We already know and discussing this issue. This issue can be closed now.

@RSDuck
Copy link
Owner

RSDuck commented Jun 9, 2018

we better keep it open, so everybody knows how the status is on this problem

@RSDuck RSDuck reopened this Jun 9, 2018
@fennectech
Copy link

fennectech commented Jun 14, 2018

Thanks. Was about to report this xD I think the text is there but it is hiding in the black I can test for you. It happens irrelevant of resolution. Same on all of them.

@dene-
Copy link
Contributor

dene- commented Jun 14, 2018

Actually all UI elements positions are hardcoded for 720p screen, they only need to be updated to 1080p.

int uiMargins[SOMEMAXSIZE][SOMEMAXSIZE];

typedef enum {
  HANDLED,
  DOCKED
} ScreenMode;

typedef enum {
  marginOne,
  marginTwo,
  paddingOne,
  ...
}

void init() /* or on framebuffer size change, if possible */ {
  uiMargins[HANDLED][marginOne] = someValue;
uiMargins[DOCKED][marginOne] = someOtherValue;
}

Probably not the best option but that it might be easier to maintain, to some extent.

@fennectech
Copy link

Well. I only last week upgraded to a 1080 tv. Plus the internal panel is 720p so a 1080p signal could cause issues. If we run at 720p even on 1080p displays that should solve our problem

@deltaryz
Copy link

There's no reason it can't change the resolution based on the display. That's what the rest of the system does - runs at 720p in handheld, and 1080p while docked. It's not locked to one hardcoded resolution, it can change.

@fennectech
Copy link

So we would be adding profiles for 480p and 720p that are selected based on the display were using?

@RSDuck
Copy link
Owner

RSDuck commented Jun 14, 2018

no, the "profile" thing is something completely internal. You really don't have to care about it.

@dene-
Copy link
Contributor

dene- commented Jun 15, 2018

If someone has a TV to test DM me on Discord to test a dev build! (My Discord is on GBATemp signature)

@fennectech
Copy link

What’s your discord username.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants