Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): unread style not working, bring views back #2765

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Feb 16, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

vercel bot commented Feb 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2025 10:10am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Feb 16, 2025 10:10am

@follow-reviewer-bot
Copy link

Suggested PR Title:

feat: add Audios & Notifications views, update animations

Change Summary:
Added new views for Audios and Notifications in the app. Updated entry list components to use ReAnimated instead of Animated. This enhances the performance and appearance of the animations.

Code Review:

Code Review

Issues Requiring Change Requests:

  1. File: apps/mobile/src/constants/views.tsx
    Lines: 7, 8
    Issue: The newly added imports for AnnouncementCuteFiIcon and MicCuteFiIcon are relative imports. Since the project uses src alias path imports (as evidenced by other imports in the code like @follow/constants), it would be more consistent and better practice to use absolute imports, e.g., "@/src/icons/...". This ensures clarity and avoids potential issues with relative paths during refactoring or file moves.
    Suggested Fix: Update the imports to use absolute paths, e.g., import { AnnouncementCuteFiIcon } from "@/src/icons/announcement_cute_fi".

  2. File: apps/mobile/src/modules/entry-list/entry-list-article.tsx
    Lines: 5, 10
    Issue: The alias for the react-native-reanimated library (ReAnimated) deviates from the standard usage where Animated or Reanimated is commonly used (with no camel casing). This can introduce confusion for future contributors and lacks consistency with community conventions.
    Suggested Fix: Consider renaming the alias to Reanimated or Animated for standardization.

  3. File: apps/mobile/src/modules/entry-list/entry-list-social.tsx** **Lines**: 5, 10 **Issue**: Similar to the previous file, the alias for the react-native-reanimatedmodule isReAnimated, which is not consistent with community conventions. **Suggested Fix**: Rename the alias to follow standard usage, such as ReanimatedorAnimated`.


Summary

Consistency and clarity in code are essential for maintainability and collaboration, especially in a project involving multiple contributors. Addressing the above issues will enhance both the maintainability and readability of the code.

After implementing these changes, the code will adhere better to common conventions and project standards.

@hyoban hyoban enabled auto-merge (squash) February 16, 2025 10:09
@hyoban hyoban merged commit fad9f94 into dev Feb 16, 2025
11 checks passed
@hyoban hyoban deleted the fix/unread-style branch February 16, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant