Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of local ports #29

Open
RussellJoyce opened this issue Apr 24, 2020 · 1 comment
Open

Improve handling of local ports #29

RussellJoyce opened this issue Apr 24, 2020 · 1 comment
Assignees

Comments

@RussellJoyce
Copy link
Member

Currently if two sessions are started from the same machine with the same port (even with two different users) then the second session will fail to create the SSH tunnel but will appear to have connected nonetheless. This can lead to multiple users hijacking one session due to everyone using the default port (12345) and then connecting to this in Vivado/SDK.

While users can specify a custom port using the -l option to the client script, this needs to be clearer as an option, and if the port cannot be used then the script needs to fail rather than carrying on regardless.

Using a random default port would help with this, but then the VLAB connection in the Xilinx tools will have to be modified frequently, which is likely to cause problems.

An alternative could be to assign (or calculate) a different default port for each user, or to just encourage (or force) people to specify a custom port when connecting.

RussellJoyce added a commit that referenced this issue Apr 24, 2020
This stops a user from accidentally opening a connection without
actually creating a tunnel, but no error handling is done at the moment.

First step towards fixing #29.
RussellJoyce added a commit that referenced this issue Apr 27, 2020
@iangray001
Copy link
Contributor

I improved the detection and error reporting in the client script, but this is still all a bit of a hack.

Unfortunately, because Vivado needs to be told the port to connect on, entirely random ports does not help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants