fix(cli): validate --repo filter on gitt issues list (entrius#1061)

The `--repo <owner/name>` filter added in entrius#910 compares raw user input
directly against `repository_full_name`, so:

- malformed inputs like `ownerrepo` or `owner//repo` are silently accepted
  and quietly match nothing (no error to the user);
- whitespace-padded valid inputs like `' entrius/gittensor '` fail to
  match real entries because the comparison string still contains the
  surrounding spaces.

Fix by reusing the existing `validate_repository(verify_exists=False)`
helper before any contract read, normalizing `repo_filter` to a clean
`owner/repo` string and surfacing `click.BadParameter` through the
existing `handle_exception` path so JSON consumers get a structured
`bad_parameter` error and human callers exit non-zero.

This is the same validator already used by `gitt issues register/cancel`
mutating commands, so the read-side `--repo` filter now matches the
documented contract enforced everywhere else.

## Tests

- Malformed filters (`ownerrepo`, `owner//repo`, `owner/`, `/repo`,
  `owner repo`) rejected with structured `bad_parameter` error in JSON
  mode and non-zero exit in human mode, before any contract read.
- Whitespace-padded valid filter `'  owner/repo  '` correctly matches
  the contract entry and returns the issue.
- Mixed-case filter `OWNER/REPO` still matches (preserves existing
  case-insensitive behavior).
- Valid non-matching filter returns empty list rather than all issues.

Closes entrius#1061

Author: RUNECTZ33

gittensor/cli/issue_commands/view.py

@@ -32,6 +32,7 @@
     print_network_header,
     read_issues_from_contract,
     validate_issue_id,
+    validate_repository,
     with_cli_behavior_options,
     with_network_contract_options,
 )
@@ -88,6 +89,18 @@ def issues_list(
         except click.BadParameter as e:
             handle_exception(as_json, str(e), 'bad_parameter')
 
+    # Normalize and validate the --repo filter before any contract reads so
+    # malformed input is rejected up-front and whitespace-padded valid input
+    # still matches `repository_full_name` from the contract. validate_repository
+    # strips whitespace, enforces owner/name format, and raises
+    # click.BadParameter on bad input — same contract used by mutating commands.
+    if repo_filter is not None:
+        try:
+            owner, repo_name = validate_repository(repo_filter, verify_exists=False)
+            repo_filter = f'{owner}/{repo_name}'
+        except click.BadParameter as e:
+            handle_exception(as_json, str(e), 'bad_parameter')
+
     contract_addr, ws_endpoint, network_name = _resolve_contract_and_network(
         contract,
         network,

tests/cli/test_issues_list_json.py

@@ -78,3 +78,111 @@ def test_issues_list_rejects_invalid_id_json(cli_root, runner, bad_id):
     assert payload['error']['type'] == 'bad_parameter'
     assert 'between 1 and 999999' in payload['error']['message']
     mock_read.assert_not_called()
+
+
+# ---------------------------------------------------------------------------
+# --repo filter validation (regression for #1061)
+# ---------------------------------------------------------------------------
+
+
+def _parse_json_payload(output: str) -> dict:
+    """Extract and parse the JSON object from CLI output.
+
+    Some success paths print a `Network: <name> • Contract: <addr>` header
+    before the JSON body, which trips json.loads on the raw output. Slice
+    from the first '{' so the parse is robust regardless of header presence.
+    """
+    start = output.find('{')
+    if start < 0:
+        raise AssertionError(f'no JSON object found in output: {output[:200]!r}')
+    return json.loads(output[start:])
+
+
+@pytest.mark.parametrize('bad_repo', ['ownerrepo', 'owner//repo', 'owner/', '/repo', 'owner repo'])
+def test_issues_list_rejects_malformed_repo_filter_json(cli_root, runner, bad_repo):
+    """Malformed --repo input must fail validation up-front before any contract read."""
+    with patch('gittensor.cli.issue_commands.view.read_issues_from_contract') as mock_read:
+        result = runner.invoke(
+            cli_root, ['issues', 'list', '--json', '--repo', bad_repo], catch_exceptions=False
+        )
+
+    assert result.exit_code != 0
+    payload = json.loads(result.output)
+    assert payload['success'] is False
+    assert payload['error']['type'] == 'bad_parameter'
+    mock_read.assert_not_called()
+
+
+@pytest.mark.parametrize('bad_repo', ['ownerrepo', 'owner//repo'])
+def test_issues_list_rejects_malformed_repo_filter_human(cli_root, runner, bad_repo):
+    """Human-mode --repo malformed input must also exit non-zero before contract read."""
+    with patch('gittensor.cli.issue_commands.view.read_issues_from_contract') as mock_read:
+        result = runner.invoke(cli_root, ['issues', 'list', '--repo', bad_repo], catch_exceptions=False)
+
+    assert result.exit_code != 0
+    mock_read.assert_not_called()
+
+
+def test_issues_list_repo_filter_strips_whitespace_json(cli_root, runner):
+    """Whitespace-padded valid --repo input must trim and match contract repository_full_name."""
+    with (
+        patch(
+            'gittensor.cli.issue_commands.view._resolve_contract_and_network',
+            return_value=('5Fakeaddr', 'ws://x', 'test'),
+        ),
+        patch('gittensor.cli.issue_commands.view.read_issues_from_contract', return_value=FAKE_ISSUES),
+    ):
+        result = runner.invoke(
+            cli_root,
+            ['issues', 'list', '--json', '--repo', '  owner/repo  '],
+            catch_exceptions=False,
+        )
+
+    assert result.exit_code == 0
+    payload = _parse_json_payload(result.output)
+    assert payload['success'] is True
+    assert payload['issue_count'] == 1
+    assert payload['issues'][0]['repository_full_name'] == 'owner/repo'
+
+
+def test_issues_list_repo_filter_case_insensitive_json(cli_root, runner):
+    """--repo filter should match contract entries regardless of case (preserved existing behavior)."""
+    with (
+        patch(
+            'gittensor.cli.issue_commands.view._resolve_contract_and_network',
+            return_value=('5Fakeaddr', 'ws://x', 'test'),
+        ),
+        patch('gittensor.cli.issue_commands.view.read_issues_from_contract', return_value=FAKE_ISSUES),
+    ):
+        result = runner.invoke(
+            cli_root,
+            ['issues', 'list', '--json', '--repo', 'OWNER/REPO'],
+            catch_exceptions=False,
+        )
+
+    assert result.exit_code == 0
+    payload = _parse_json_payload(result.output)
+    assert payload['success'] is True
+    assert payload['issue_count'] == 1
+
+
+def test_issues_list_repo_filter_no_match_returns_empty_json(cli_root, runner):
+    """Valid but non-matching --repo input returns empty list, not all issues."""
+    with (
+        patch(
+            'gittensor.cli.issue_commands.view._resolve_contract_and_network',
+            return_value=('5Fakeaddr', 'ws://x', 'test'),
+        ),
+        patch('gittensor.cli.issue_commands.view.read_issues_from_contract', return_value=FAKE_ISSUES),
+    ):
+        result = runner.invoke(
+            cli_root,
+            ['issues', 'list', '--json', '--repo', 'other/repo'],
+            catch_exceptions=False,
+        )
+
+    assert result.exit_code == 0
+    payload = _parse_json_payload(result.output)
+    assert payload['success'] is True
+    assert payload['issue_count'] == 0
+    assert payload['issues'] == []