Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error handling in cb.py #378

Conversation

paul-l1
Copy link

@paul-l1 paul-l1 commented Jan 23, 2025

closes #377

@djs0109
Copy link
Contributor

djs0109 commented Jan 27, 2025

@paul-l1 Thanks for the quick fix! Could you please provide a minimal example to reproduce the error that you had? Specifically, I would like to know when the err.response is None will be True , because this could also be a general issue for other clients in filip

@paul-l1
Copy link
Author

paul-l1 commented Jan 29, 2025

@paul-l1 Thanks for the quick fix! Could you please provide a minimal example to reproduce the error that you had? Specifically, I would like to know when the err.response is None will be True , because this could also be a general issue for other clients in filip

The err.response can be None for many reasons. In my case it was an SSLError, which could be reproduced like raise requests.exceptions.SSLError("test"). There are other possible errors like requests.exceptions.ConnectionError, requests.exceptions.Timeout, requests.exceptions.InvalidURL. Those errors can be caused by problems with network connection or certificate verification failures.

@djs0109 djs0109 changed the base branch from master to 377-fix-error-handling-in-ContextBrokerClient January 29, 2025 14:03
@djs0109 djs0109 merged commit 68aa210 into RWTH-EBC:377-fix-error-handling-in-ContextBrokerClient Jan 29, 2025
@djs0109
Copy link
Contributor

djs0109 commented Jan 29, 2025

@paul-l1 I move the PR here #382 to activate the CI/CD workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix error handling in ContextBrokerClient
2 participants