Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Authorization header not included when calling specific endpoints #20

Open
hgrgic opened this issue Oct 4, 2023 · 1 comment
Open

Comments

@hgrgic
Copy link

hgrgic commented Oct 4, 2023

When OIDC is enabled on the OHIF viewer and I try calling endpoints such as searchImageSets or getImageSetMetadata Authorization header is not included. However, when I try to open an image and getImageFrame is called then the Authorization header is included.

I would like to always have Authorization header present so I could enable authorization flow on my proxy.
I suspect the behaviour between endpoints is different as getImageFrame is using xhr while other two endpoints are using fetch.

Could you please confirm if this is actually the case?

@mateusfreira
Copy link
Collaborator

mateusfreira commented Oct 5, 2023

Hey @hgrgic thanks for your report, it may be a case that we have not faced yet ... in our case, we don't have yet any using OIDC with health imaging.

I double-checked the code in the file src/imageLoader/loadImageSets.ts:49 we are not checking for the OIDC (AuthService headers), which would be an interesting improvement for sure.

I will keep this issue open to implement that in the next releases. The implementation would be around the loadImageSets and check the auth service header before adding the headers from the aws signature.

PRs are welcome too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants